Closed
Bug 509301
Opened 12 years ago
Closed 12 years ago
Value chosen for callee in args_resolve is nonsense
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jorendorff, Assigned: jorendorff)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
824 bytes,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Symptomless bug, but the reinterpret_cast I just introduced in bug 506721 would actually be kind of dangerous if the value were used. It's not.
Assignee | ||
Comment 1•12 years ago
|
||
Assignee: general → jorendorff
Attachment #393425 -
Flags: review?(jwalden+bmo)
Assignee | ||
Comment 2•12 years ago
|
||
Uh, to clarify, it's not the reinterpret_cast that's dangerous. That INT_TO_JSVAL was already meaningless before my change. The change in bug 506721 didn't affect the meaning of that code, except I guess it might flunk an assertion now.
Comment 3•12 years ago
|
||
The patch for bug 507573 had a s/OBJECT/INT/ thinko affecting the line in question. Better to use null or undefined, since the getter never reads *vp and only writes it, for sure. /be
Updated•12 years ago
|
Attachment #393425 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 4•12 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/3d4074b8928e dvander reports that bug 506721 causes an assertion in debug browser builds. This might fix it. If not, the assertion is catching a thinko somewhere else...
Blocks: 506721
Assignee | ||
Updated•12 years ago
|
Whiteboard: fixed-in-tracemonkey
Comment 5•12 years ago
|
||
(In reply to comment #4) > http://hg.mozilla.org/tracemonkey/rev/3d4074b8928e > > dvander reports that bug 506721 causes an assertion in debug browser builds. Isn't the bug dvander filed bug 509557 ? It's different, but there could be more like it. /be
Assignee | ||
Comment 6•12 years ago
|
||
Right, my patch in bug 506721 added two assertions, each of which trips on every debug browser startup, due to pre-existing bugs. The first is bug 509557. I don't see the other one on file yet. Maybe I'm searching wrong.
Comment 7•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3d4074b8928e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•