509308 - [WinMo] Fix non-fatal configure errors like "'pthread.h': No such file or directory"

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Serge Gautherie (:sgautherie)]

At first, I wondered how my patch could have caused this.
Then, I realized these errors are always there: confusing :-/

Brief Log from a green build:
{
http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1249795891.1249798451.30937.gz&fulltext=1
WinMo try hg build on 2009/08/08 22:31:31

make[3]: *** [export] Error 1
dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
make[3]: *** [export] Error 1
}

Comment 2

[(not currently active) Ted Mielczarek]

This is apparently from configure, full context:

checking for pthread_create in -lpthreads... dummy.c
NEXT ERROR dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
-o is -o
no
checking for pthread_create in -lpthread... dummy.c
NEXT ERROR dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
-o is -o
no
checking for pthread_create in -lc_r... dummy.c
NEXT ERROR dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
-o is -o
no
checking for pthread_create in -lc... dummy.c
NEXT ERROR dummy.c(2) : fatal error C1083: Cannot open include file: 'pthread.h': No such file or directory
-o is -o
no

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> This is apparently from configure

This is what bug summary says ;->

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> checking for pthread_create in -lpthreads... dummy.c

And bug description implicitly says it's in dummy.c ;->

Comment 5

[(not currently active) Ted Mielczarek]

Sure, but what you pasted in comment 0 doesn't show precisely where the errors are occurring. Comment 2 shows that it's from the compilation of configure tests for pthreads.

Comment 7

[Nicholas Nethercote [inactive]]

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1266375195.1266375979.32548.gz

This happens quite frequently on the Tracemonkey repo.

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #7)
> http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1266375195.1266375979.32548.gz
> 
> This happens quite frequently on the Tracemonkey repo.

This happens on *every* build, its output from configure that's not being handled properly.

Comment 9

[Nicholas Nethercote [inactive]]

Brad, any idea what that output is?

Comment 10

[Nicholas Nethercote [inactive]]

(In reply to comment #8)
>
> This happens on *every* build, its output from configure that's not being
> handled properly.

Are you sure?  A Tracemonkey WinMo build just succeeded:

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1266450321.1266453120.16262.gz

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Sorry, I'll clarify, this output shows up every time configure gets run in nspr. For dep buids, if nothing pertinent gets changed it won't run. This patch should avoid running this test that should never pass.

Comment 12

[Wan-Teh Chang]

Comment on attachment 427561 [details] [diff] [review]
patch

r=wtc.  Thanks for the patch.

Sounds like this is a cosmetic issue.  I'll include it in NSPR 4.8.5.  (I'm trying to
wrap up NSPR 4.8.4 today.)

Comment 13

[Wan-Teh Chang]

Attachment: patch (as checked in)

I removed the '*' in front of "wince" and checked in the
patch on the NSPR trunk (NSPR 4.8.5).

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.268; previous revision: 1.267
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.272; previous revision: 1.271
done