509407 - while panning up, url bar displays and gets focus

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

here is what I do:
1) load cnn.com, wait for it to finish
2) pan to the bottom of the page
3) pan up towards to top of the page (expecting kinetic scrolling)
4) observe this error:

url bar is show, focus is given to it, softkb is displayed, and bookmarks are dropped down.  Then the URL bar disappears and I have no clear way to get back to browsing my webpage.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

make sure that this bug verifies the case that the url bar is not cleared when the awesomebar is panned up.  I marked bug 509384 as closed because the one issue appears to be related to this bug.

Comment 2

[Roy Frostig :froystig]

I'm not sure what you mean.  Could you clarify?

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

yeah, reading back my comment is not that clear.  What happens is when panning back up to the top of the page, the url bar displays as well as the awesomebar (in most cases).  What happens is the url bar becomes blank so even though I have never intentionally invoked the awesomebar/newurl workflow, I don't know what page I am on.

I assume when this fix is done the urlbar will have the url/title of the page until the user actually taps in there to type a new url

Comment 4

[Roy Frostig :froystig]

Attachment: awesomebar_no_magic_open

Attached is a patch that fixes the issue via a few architectural changes to MouseModule (it now behaves a bit more like the old ChromeInputHandler in some cases).

The most important change is that I've added a boolean flag to the custom draggers interface.  A custom dragger must now specify a boolean property |allowRealtimeDownUp| based on which the MouseModule will swallow or allow the propagation of the mousedown and mouseup chrome events that correspond to the beginning and end of a drag.

As a side effect, this patch also fixes bug 510003.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 394407 [details] [diff] [review]
awesomebar_no_magic_open

could we rename "allowRealtimeDownUp" to "propagateDownUp" ?I think that is a bit more clear.

Comment 6

[Stuart Parmenter]

checked in

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

verified with beta3