Closed Bug 509427 Opened 10 years ago Closed 10 years ago

Minor test suite tweaks for themes (from blog)

Categories

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clouserw, Assigned: rjwalsh)

References

Details

Attachments

(1 file)

Comment from the blog:

-------------------------------------------------------
Note that the verification suite generates lots of false hits on themes:
Things like:
chrome/littlefox.jar/browser/feedview.css (39) : Matched Pattern: “/-moz-binding:(?!\s*url\s*\(\s*["']?chrome:\/\/.*\/content\/)/”
and:
chrome.manifest (1) : Matched Pattern: “/^(?!(#|skin |style ))/”
are actually OK for themes.

So, the suite needs to be more tuned to Themes as well.

-------------------------------------------------------
We need to verify these tests and clarify if themes are different than extensions and adjust the tests accordingly.
Attached patch FixSplinter Review
Changes the remote javascript test to allow resources to be pulled from content or skin, as opposed to just content.
Changes the chrome manifest check to use the regex whitespace identifier as opposed to a space.  This will match both tabs and spaces.
Attachment #393585 - Flags: review?(clouserw)
Attachment #393585 - Flags: review?(clouserw) → review+
Fixed in r48920
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Duplicate of this bug: 509150
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.