Floating the toolbar is really slow.

VERIFIED FIXED

Status

Fennec Graveyard
General
--
critical
VERIFIED FIXED
9 years ago
7 years ago

People

(Reporter: dougt, Assigned: vingtetun)

Tracking

Details

Attachments

(1 attachment, 7 obsolete attachments)

(Reporter)

Description

9 years ago
Removing tryFloatToolbar and tryUnfloatToolbar from browser.js dramatically speed up the pan.  there is a claim that roc has a patch that fixes this performance problem.
Flags: wanted-fennec1.0?
those methods can also call "appendChild" to move the toolbar around, which can be slow.
Created attachment 394002 [details] [diff] [review]
WIP-0.1

The original goal of this bug is to remove the appendChild mechanism living in tryFloatToolbar/tryUnfloatToolbar.
Basically it used a 'position: fixed' urlbar.
Comment on attachment 394002 [details] [diff] [review]
WIP-0.1

The patch has some problems, it just a proposal to see if I need to continue in this direction.
Attachment #394002 - Attachment description: Patch v0.1 → WIP-0.1
Created attachment 394291 [details] [diff] [review]
WIP-2

Ok, I don't use any top/left hack here.
I Just want stuart feedback on that.
Attachment #394002 - Attachment is obsolete: true
Created attachment 394298 [details] [diff] [review]
WIP-3

A little explanation.

When the sidebars are visible this patch turns the urlbar into a fixed element positioned at 0,0. When they are invisible it return to the normal element flow.

The urlbar is container into a box that have the height of the it, so when we position: fixed the urlbar the content browser don't move to the top.

It's my last idea, not sure it is good.
Attachment #394291 - Attachment is obsolete: true
Created attachment 394374 [details] [diff] [review]
Patch v0.1

This is not as fast as we want but this has the advantage to remove the appendChild calls.
Attachment #394298 - Attachment is obsolete: true
Created attachment 394423 [details] [diff] [review]
Patch v0.2

Finally, I need to add one more box to the hierarchy, otherwise I have a size issue with urlbar-container (not toolbar-container) because the 'position: fixed' rule turned the display of the toolbar-main element into 'block', and in order to work flex need the parent node to have a display of '-moz-box' or '-moz-box-inline', ... so the urlbar-container won't fit the available space but use the size of it's content instead.
Attachment #394374 - Attachment is obsolete: true
Attachment #394423 - Flags: review?
Attachment #394423 - Flags: review? → review?(pavlov)
Created attachment 394513 [details] [diff] [review]
Remove the move by a pixel bug

The move by a pixel bug is related to the display type of the sidebar, it differs depending on the container.

This version correct that.

Theere is also another little pixel bug but I've filled another bug for this one : bug 510488
Attachment #394423 - Attachment is obsolete: true
Attachment #394513 - Flags: review?(pavlov)
Attachment #394423 - Flags: review?(pavlov)
Created attachment 394556 [details] [diff] [review]
Patch v0.2

Works better with zoom.
Attachment #394513 - Attachment is obsolete: true
Attachment #394513 - Flags: review?(pavlov)
Attachment #394556 - Flags: review?(pavlov)
Attachment #394556 - Flags: review?(mark.finkle)
Created attachment 394572 [details] [diff] [review]
Patch v0.4

Sorry, for the spam... I've forget to size the height of the container in the previous patch.
Attachment #394556 - Attachment is obsolete: true
Attachment #394572 - Flags: review?(pavlov)
Attachment #394572 - Flags: review?(mark.finkle)
Attachment #394556 - Flags: review?(pavlov)
Attachment #394556 - Flags: review?(mark.finkle)

Updated

9 years ago
Attachment #394572 - Flags: review?(pavlov)
Attachment #394572 - Flags: review?(mark.finkle)
Attachment #394572 - Flags: review+

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Reporter)

Updated

9 years ago
tracking-fennec: --- → ?
Flags: wanted-fennec1.0?
tracking-fennec: ? → 1.0+
how can I verify this bug?
verified with 20090827 winmo nightly trunk by sliding the side bars in and out and the url bar becomes floating.  Should be instantaneous and it is!
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.