509539 - Allow jobqueue.pl to specify where it stores its PID

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, enhancement)

Description

[Max Kanat-Alexander]

Right now, you can't change where jobqueue.pl stores its PID without editing the code. As justdave pointed out, this makes it hard for multi-server situations where data/ is NFS-mounted (Mozilla).

The attached patch allows you to specify the PID, the name of the process for the log file (which will help our sysv init script), and also fixes a bug that "progname" was actually being ignored and was always $0.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Comment 2

[David Lawrence [:dkl]]

(In reply to comment #1)
> Created an attachment (id=393602) [details]
> v1

I have just returned from a week off so I should be able to look at this on
Monday EDT.

Dave

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 393602 [details] [diff] [review]
v1

>===================================================================
>+   -p dir    Specify the file where jobqueue.pl should store its current
>+             process id. Defaults to F<data/jobqueue.pl.pid>.

This should be 

     -p pidfile ...

as "dir" is incorrect. For example if you want the pid file in data/jobqueue/
and say " -p data/jobqueue" it gives error that that is a directory and not
a file.

Otherwise everything worked as expected and I don't have any other issues with the code.

Dave

Comment 4

[Max Kanat-Alexander]

Attachment: v2

Comment 5

[David Lawrence [:dkl]]

Comment on attachment 394906 [details] [diff] [review]
v2

Looks good. r=dkl

Comment 6

[Max Kanat-Alexander]

tip:

Checking in jobqueue.pl;
/cvsroot/mozilla/webtools/bugzilla/jobqueue.pl,v  <--  jobqueue.pl
new revision: 1.3; previous revision: 1.2
done
Checking in Bugzilla/JobQueue/Runner.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/JobQueue/Runner.pm,v  <--  Runner.pm
new revision: 1.4; previous revision: 1.3
done


3.4:

Checking in jobqueue.pl;
/cvsroot/mozilla/webtools/bugzilla/jobqueue.pl,v  <--  jobqueue.pl
new revision: 1.2.2.1; previous revision: 1.2
done
Checking in Bugzilla/JobQueue/Runner.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/JobQueue/Runner.pm,v  <--  Runner.pm
new revision: 1.2.2.2; previous revision: 1.2.2.1
done