509697 - need to update (and turn on?) tree closure hook for new branches

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[[e-mail] (:bhearsum)]

I just noticed that Electrolysis, Places, and maybe others aren't in that hook. We should get them added.

Comment 1

[(not currently active) Ted Mielczarek]

Might as well get 1.9.2 in there while we're at it.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: update tree closure hook for Places, Electrolysis, 1.9.2

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 394018 [details] [diff] [review]
update tree closure hook for Places, Electrolysis, 1.9.2

Looks fine. Want to throw tracemonkey in to complete the set? Currently I think enabling the hook on individual repos is opt-in for project branches, should we make that a standard part of project branch setup? The hook doesn't really do anything unless you stick the magic CLOSED bits in the tree status anwyay.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to comment #3)
> (From update of attachment 394018 [details] [diff] [review])
> Looks fine. Want to throw tracemonkey in to complete the set? Currently I think
> enabling the hook on individual repos is opt-in for project branches, should we
> make that a standard part of project branch setup? The hook doesn't really do
> anything unless you stick the magic CLOSED bits in the tree status anwyay.

I'll update it for TraceMonkey, too.

Shawn/Benjamin/Rob: Do you guys want the hook turned on for Places/Electrolysis/TraceMonkey?

Comment 5

[[e-mail] (:bhearsum)]

Attachment: [checked in] with tracemonkey

Comment 6

[Benjamin Smedberg]

If you like... it doesn't much matter to me.

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 394035 [details] [diff] [review]
[checked in] with tracemonkey

changeset:   17:4ca4ef575884

Comment 8

[Shawn Wilsher :sdwilsh]

Doesn't matter to me for places.