Closed Bug 509697 Opened 11 years ago Closed 11 years ago

need to update (and turn on?) tree closure hook for new branches

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(1 file, 1 obsolete file)

I just noticed that Electrolysis, Places, and maybe others aren't in that hook. We should get them added.
Might as well get 1.9.2 in there while we're at it.
Attachment #394018 - Flags: review?(ted.mielczarek)
Comment on attachment 394018 [details] [diff] [review]
update tree closure hook for Places, Electrolysis, 1.9.2

Looks fine. Want to throw tracemonkey in to complete the set? Currently I think enabling the hook on individual repos is opt-in for project branches, should we make that a standard part of project branch setup? The hook doesn't really do anything unless you stick the magic CLOSED bits in the tree status anwyay.
Attachment #394018 - Flags: review?(ted.mielczarek) → review+
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
(In reply to comment #3)
> (From update of attachment 394018 [details] [diff] [review])
> Looks fine. Want to throw tracemonkey in to complete the set? Currently I think
> enabling the hook on individual repos is opt-in for project branches, should we
> make that a standard part of project branch setup? The hook doesn't really do
> anything unless you stick the magic CLOSED bits in the tree status anwyay.

I'll update it for TraceMonkey, too.

Shawn/Benjamin/Rob: Do you guys want the hook turned on for Places/Electrolysis/TraceMonkey?
Attachment #394018 - Attachment is obsolete: true
If you like... it doesn't much matter to me.
Attachment #394035 - Attachment description: with tracemonkey → [checked in] with tracemonkey
Depends on: 509989
Doesn't matter to me for places.
Depends on: 510492
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
No longer depends on: 510492
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.