509785 - Search dehydra system scripts in the same directory as the user script

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Diego Novillo]

Dehydra searches for its own scripts in the same directory where gcc_dehydra.so lives.  In our build system this is not a good location as it would mean replicating the system scripts in several directories.

This patch makes dehydra look for its scripts in the same directory where the user script lives.  This may only be useful for our internal installation, though.

Comment 1

[Diego Novillo]

Attachment: Search system scripts in the same directory where the user script is.

The setting for STD_INCLUDE is needed for running the dehydra testsuite.  Otherwise, it fails to find dehydra.js, since it execute under tests.

Comment 2

[(dormant account)]

While I agree with you that the current system path situation sucks, this patch is not a step in the right direction.

I think the proper solution is to support a compile-time install path. My preferred way would be
to do ./configure --prefix=/path/to/dehydra/lib/
This would default to `pwd`/lib and you'd be able to override it.

Alternatively we could settle for a crappier solution by something like
./configure --library_path_relative_to=dehydra.so|dehydra_script
ie to toggle between what we do currently and what your patch does.

Comment 3

[Diego Novillo]

(In reply to comment #2)
> While I agree with you that the current system path situation sucks, this patch
> is not a step in the right direction.
> 
> I think the proper solution is to support a compile-time install path. My
> preferred way would be
> to do ./configure --prefix=/path/to/dehydra/lib/
> This would default to `pwd`/lib and you'd be able to override it.
> 
> Alternatively we could settle for a crappier solution by something like
> ./configure --library_path_relative_to=dehydra.so|dehydra_script
> ie to toggle between what we do currently and what your patch does.

How about a -fplugin-arg-dehydra-library-path=<path> solution?  The default value for this would be provided at compile-time, but this would allow relocating scripts which gives us better control over where to put things.

If that's acceptable, I will prepare a patch.  Otherwise, it should not be a big patch to maintain locally.

Comment 4

[(dormant account)]

(In reply to comment #3)

> How about a -fplugin-arg-dehydra-library-path=<path> solution?  The default
> value for this would be provided at compile-time, but this would allow
> relocating scripts which gives us better control over where to put things.
> 
> If that's acceptable, I will prepare a patch.  Otherwise, it should not be a
> big patch to maintain locally.

sounds great.

Comment 5

[Joshua Cranmer [:jcranmer]]

Dehydra and treehydra are no longer maintained by Mozilla.