509876 - Clean up SyncFrameViewGeometryDependentProperties

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Markus Stange [:mstange]]

Attachment: v1

This is extracted from the patch in bug 357725.
-- SyncFrameViewGeometryDependentProperties doesn't have to do anything with geometry, so rename it to SyncWindowProperties.
-- The conditions at its beginning only hold when SyncFrameViewAfterReflow is called from PresShell::DoReflow or when SyncFrameViewProperties is called from nsCSSFrameConstructor::ConstructRootFrame. Move the calls to SyncWindowProperties there.
-- Set the window shadow on the window widget instead of on the child widget.
-- Support setting window shadow on sheets, too, except that it doesn't work (maybe a Cocoa limitation).

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 393968 [details] [diff] [review]
v1

+GetPresContextWidget(nsPresContext* aPresContext)

The name should be GetPresContextContainerWidget, I think

Comment 2

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/43943b452c0e