Create nsChildView::GetCocoaWindow

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
Widget: Cocoa
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla1.9.3a1
All
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 393980 [details] [diff] [review]
v1

The code to get the view's nsCocoaWindow is duplicated three times, let's pull it out into a method.
Attachment #393980 - Flags: review?(joshmoz)

Comment 1

9 years ago
Comment on attachment 393980 [details] [diff] [review]
v1

The point of the delegate checking is to ensure that we get a XUL native window, not just any native window (from an embedder).

This being the case, the new method is inappropriately named. It won't work in the embedding situation, it will return nsnull, and the name should reflect that. How about "GetXULNativeWindowWidget"?
(Assignee)

Comment 2

9 years ago
You're right, the current name is no good. I think I'd prefer GetXULWindowWidget (without the "Native"), because "native window" usually means "some Cocoa object, like NSWindow*". Do you agree?

Comment 3

9 years ago
I agree.
(Assignee)

Comment 4

9 years ago
Created attachment 394212 [details] [diff] [review]
v2

Same patch with new name.
Attachment #393980 - Attachment is obsolete: true
Attachment #394212 - Flags: review?(joshmoz)
Attachment #393980 - Flags: review?(joshmoz)

Updated

9 years ago
Attachment #394212 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/6b30334ec120
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
(Assignee)

Updated

9 years ago
Target Milestone: --- → mozilla1.9.3
Target Milestone: mozilla1.9.3 → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.