Closed Bug 509987 Opened 12 years ago Closed 12 years ago

No need to create app.ico in $(DIST)/branding/app.ico

Categories

(Thunderbird :: Build Config, defect)

All
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: standard8, Assigned: standard8)

References

()

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
We are currently copying something to $(DIST)/branding/app.ico on Windows despite the fact we don't actually then use it for anything. Lets just drop the copy.
Attachment #394052 - Flags: review?(philringnalda)
Comment on attachment 394052 [details] [diff] [review]
The fix

Q. So why did we ever start copying it?
A. Because it was the third part of Watermrk.bmp, Header.bmp and app.ico that were used in building the pre-NSIS installer, it just wasn't as obviously only used by it.
Attachment #394052 - Flags: review?(philringnalda) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/5816c74846e8
Status: NEW → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.