Closed Bug 510028 Opened 16 years ago Closed 16 years ago

binaryurl is not branch-specific in tinderbox headers

Categories

(Release Engineering :: General, defect, P2)

Product:
Release Engineering
Component:
General
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: coop, Assigned: coop)

Details

(Whiteboard: [l10n])

Attachments

(1 file, 1 obsolete file)

Append '-l10n' to the en-US binary URL
1.30 KB, patch
armenzg
: review+
coop
: checked-in+
Details | Diff | Splinter Review
Axel noticed today that the binaryurl listed in the tinderbox build log headers always points to mozilla-central. e.g. from http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n/1250087349.1250087418.31857.gz&fulltext=1 : tinderbox: tree: Mozilla-l10n tinderbox: builddate: 1250087349 tinderbox: status: success tinderbox: build: Firefox mozilla-1.9.1 linux l10n tinderbox: errorparser: unix tinderbox: binaryurl: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central-l10n/ tinderbox: logcompression: bzip2 tinderbox: logencoding: base64 tinderbox: END This looks like a simple fix to make if use config['enUS_binaryURL'] to set the binaryURL rather than hard-coding here: http://hg.mozilla.org/build/buildbotcustom/file/7b3c9c41fbc9/misc.py#l174 http://hg.mozilla.org/build/buildbotcustom/file/7b3c9c41fbc9/misc.py#l186
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #394094 - Flags: review?(armenzg)
Attachment #394094 - Flags: review?(armenzg) → review+
Comment on attachment 394094 [details] [diff] [review] Use enUS_binaryURL from config in TinderboxMailNotifier http://hg.mozilla.org/build/buildbotcustom/rev/77beb8304501
Attachment #394094 - Flags: checked-in+
Production masters updated and reconfig-ed.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Actually, we should use the en-US url plus -l10n, as the builds don't get uploaded to en-US ;-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [l10n]
Status: REOPENED → ASSIGNED
Attachment #394094 - Attachment is obsolete: true
Attachment #397620 - Flags: review?(armenzg)
Attachment #397620 - Flags: review?(armenzg) → review+
Attachment #397620 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: