Closed
Bug 510031
Opened 16 years ago
Closed 16 years ago
Registration Form Error Message for Taken Nicknames Should be in Red or in Bold
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
addons.mozilla.org Graveyard
Public Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.0.9
People
(Reporter: retornam, Assigned: Milos)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
541 bytes,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
Steps to reproduce:
visit https:/addons.mozilla.org/en-US/firefox/users/register
fill out the required information
in the nickname field enter retornam
Click register
Expected results:
Error message stating that the nickname retornam has already been used
Actual Results:
There are errors in this form. Please correct them and resubmit. Error Message
Comment 1•16 years ago
|
||
The error shows up in the form, it should just be emphasized.
| Reporter | ||
Updated•16 years ago
|
Summary: Registration Form Displays Wrong Message for Already Taken Username → Registration Form Error Message for Taken Nicknames Should be in Red or in Bold
| Assignee | ||
Comment 2•16 years ago
|
||
| Assignee | ||
Updated•16 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → 5.0.9
Updated•16 years ago
|
Attachment #394098 -
Flags: review?(fwenzel) → review-
Comment 3•16 years ago
|
||
Comment on attachment 394098 [details] [diff] [review]
patch v1
Sorry, but this CSS rule is too general, it'll affect other parts of the page too that use the class "error-message". We should either reuse an error message class that already exists, or make one that is specific enough to stay restricted to this (and maybe other?) form errors.
Comment 4•16 years ago
|
||
We also need to use -webkit-border-radius and plain old 'border-radius' to be compatible with other browsers.
| Assignee | ||
Comment 5•16 years ago
|
||
Attachment #394098 -
Attachment is obsolete: true
Attachment #395512 -
Flags: review?(clouserw)
Updated•16 years ago
|
Attachment #395512 -
Flags: review?(clouserw) → review+
Comment 6•16 years ago
|
||
Comment on attachment 395512 [details] [diff] [review]
patch v2
r+ after changing .amoform to .amo-form
Comment 7•16 years ago
|
||
r49608, thanks Milos
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
| Reporter | ||
Comment 8•16 years ago
|
||
verified fixed on https://preview.addons.mozilla.org/en-US/firefox/users/register
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•