If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

"ASSERTION: should not have pseudo-element data"

RESOLVED FIXED in mozilla1.9.3a1

Status

()

Core
CSS Parsing and Computation
P3
normal
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Jesse Ruderman, Assigned: dbaron)

Tracking

({assertion, testcase})

Trunk
mozilla1.9.3a1
assertion, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
layout/style/crashtests/437170-1.html triggers

###!!! ASSERTION: should not have pseudo-element data: 'mPseudo || !mStyleContextHolder->HasPseudoElementData()', file layout/style/nsComputedDOMStyle.cpp, line 479
Flags: in-testsuite+
(Assignee)

Comment 1

8 years ago
This is, um, rather interesting.  The style context in question is the grandchild of a style context with (a) null parent and (b) :-moz-non-element internal pseudo.

I guess that's the result of GetStyleContextForContent's handling of document fragments.  That handling was introduced a long time ago:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/extensions/inspector/base/src/inDOMUtils.cpp&rev=1.15
and I think we should instead skip non-element parents.
(Assignee)

Comment 2

8 years ago
Created attachment 394156 [details] [diff] [review]
patch
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #394156 - Flags: review?(bzbarsky)
Attachment #394156 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

8 years ago
http://hg.mozilla.org/mozilla-central/rev/a8caf6d22376
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
OS: Mac OS X → All
Priority: -- → P3
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3
(Assignee)

Comment 4

8 years ago
Comment on attachment 394156 [details] [diff] [review]
patch

Simple fix to do less-weird things, to fix an assertion introduced a few days ago.
Attachment #394156 - Flags: approval1.9.2?
Target Milestone: mozilla1.9.3 → mozilla1.9.3a1
Attachment #394156 - Flags: approval1.9.2? → approval1.9.2+
(Assignee)

Comment 5

8 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7e638f4faf28
status1.9.2: --- → beta1-fixed
You need to log in before you can comment on or make changes to this bug.