510071 - "ASSERTION: should not have pseudo-element data"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Jesse Ruderman]

layout/style/crashtests/437170-1.html triggers

###!!! ASSERTION: should not have pseudo-element data: 'mPseudo || !mStyleContextHolder->HasPseudoElementData()', file layout/style/nsComputedDOMStyle.cpp, line 479

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is, um, rather interesting.  The style context in question is the grandchild of a style context with (a) null parent and (b) :-moz-non-element internal pseudo.

I guess that's the result of GetStyleContextForContent's handling of document fragments.  That handling was introduced a long time ago:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/extensions/inspector/base/src/inDOMUtils.cpp&rev=1.15
and I think we should instead skip non-element parents.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/a8caf6d22376

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 394156 [details] [diff] [review]
patch

Simple fix to do less-weird things, to fix an assertion introduced a few days ago.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7e638f4faf28