510072 - Security Notice box covers Thunderbird links

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[James Socol [:jsocol, :james]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: 

The div.simplebox element containing the Flash Security notice stretches over the Thunderbird links.

Reproducible: Always

Steps to Reproduce:
1. Launch IE7.
2. Go to support.mozilla.com

Actual Results:  
The warning covers the Thunderbird links

Expected Results:  
The warning should be within the column.

The issue seems to be with block-level widths containing the div.simplebox, not the div itself.

Comment 1

[James Socol [:jsocol, :james]]

Attachment: patch, v1

Tweaks mozcommon.css, mozcommon/ie.css and mozcommon/ie7.css to fix the box widths and stop the box from overflowing in Firefox, IE6 and IE7.

Comment 2

[Paul Craciunoiu [:paulc]]

Comment on attachment 394139 [details] [diff] [review]
patch, v1

This clips the topbar image on the right a bit. Also, it includes duplicated CSS from bug 495831 :)
Remember to do an "svn update"  -- since that bug has just been committed -- to avoid this.

Comment 3

[Paul Craciunoiu [:paulc]]

(In reply to comment #2)
> (From update of attachment 394139 [details] [diff] [review])
> This clips the topbar image on the right a bit. Also, it includes duplicated
> CSS from bug 495831 :)
In IE6, at least.

Comment 4

[James Socol [:jsocol, :james]]

Attachment: patch, v2

This one doesn't include the duplicate code from #495831 and fixes the background clipping in IE6.

Comment 5

[Paul Craciunoiu [:paulc]]

Comment on attachment 394158 [details] [diff] [review]
patch, v2

Looks good on IE6. My IE7 won't load either VPN or my local so I can't test that. I'll commit to the forumux branch so Stephen can test.

Comment 6

[[:Cww]]

would it be easier if you gave us another way to put URGENT and high-priority messages on the front page?

Comment 7

[Paul Craciunoiu [:paulc]]

r49061 on forumux branch.
http://sumo-forumux.stage.mozilla.com/en-US/kb/

Comment 8

[Paul Craciunoiu [:paulc]]

I see this one of two ways:
* content labels and style that ugly notice
* current situation, still style that ugly notice

I guess content labels would provide better control (independent) and give localizers less hassle, yes?

Comment 9

[James Socol [:jsocol, :james]]

Adding a simple field to the admin pages isn't terribly difficult. It could be incorporated into the template. Similar to the maintenance message but without closing the site.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot w/fix

Comment 11

[Paul Craciunoiu [:paulc]]

Fixed with jsocol's patch (attachment 394158 [details] [diff] [review])
r49140 / r49142

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

* Firefox 3.5.2
* Firefox 3.0.13
* IE 6/7/8
* Safari 4
* Opera 9.64
* Google Chrome 2.0.172.39

Comment 13

[Paul Craciunoiu [:paulc]]

Regression for rest of pages, general page width is affected. Reopening so we don't push this thinking it's fixed :D

Comment 14

[James Socol [:jsocol, :james]]

Attachment: patch, v3

Reverts the previous, over-broad changes and changes just the box.

In the future, we should revert this change and stop using the "simplebox" class for both front-page notices and call-out paragraphs in wiki pages.

Comment 15

[Paul Craciunoiu [:paulc]]

Comment on attachment 395100 [details] [diff] [review]
patch, v3

I talked to James and it makes most sense to do this IE 7 fix for now and figure out a better way to add notifications to the home page later. In the meantime this patch will undo the regression above but also narrow the width on simpleboxes on wiki pages by a bit, which is acceptable for now.

Note that this fix only applies for IE 7.

We'll leave the bug open and find a better way in the future.

r49437 / r49438

Comment 16

[James Socol [:jsocol, :james]]

If we want a better way of doing front-page notices, we should open a new bug for that.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

To verify this, I just double-check layout in IE 7, right?

Comment 18

[James Socol [:jsocol, :james]]

(In reply to comment #17)
> To verify this, I just double-check layout in IE 7, right?

That should do it.

Comment 19

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.