510152 - Check for failure onStopRequest and throw the error for extra debugging

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ed Lee :Mardak]

Right now the third arg to onStopRequest is ignored (and is labeled "time") for some reason, but it's actually the nsresult code. It could be failure, and because we ignore it now, the code after chanOpen to do channel.requestSucceeded usually throws ns_not_initialized or something.

So if we throw the error, we can figure out what the real failure is.

Comment 1

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/a807b167f776
Wrap the error code with a JS Error to track the stack, and re-wrap it to get the full stack trace. Also, remove args for __request for the stack because it's sometimes the whole record..