510159 - Cleanup CSS fonts for preferences and move some CSS presentation rules into the right file

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

On hildon, the preferences panel fonts are not sized relative to the right core font-size. Changing to use :root for the font styles fixes that.

Some of the styles in chrome/content/browser.css are presentational, not just for bindings. Those need to be moved to themes/hildon/platform.css and themes/wince/platform.css

We need to settle on percentages or points for fonts, but that's a different bug.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Mark, can we also remove all the #browser-container rules in chrome/content/browser.css since these are unused now?

#browser-container > * { 
  -moz-stack-sizing: ignore;
}

#browser-container > spacer {
  width: 1px;
  height: 1px;
}

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> Mark, can we also remove all the #browser-container rules in
> chrome/content/browser.css since these are unused now?
> 
> #browser-container > * { 
>   -moz-stack-sizing: ignore;
> }
> 
> #browser-container > spacer {
>   width: 1px;
>   height: 1px;
> }

Yes, I can remove those

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

same as previous but removes extra unused rules

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 394221 [details] [diff] [review]
patch

nit: remove these rules too :)

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/1e46ef23090f

Comment 6

[Dão Gottwald [:dao]]

bugspam