Closed Bug 510208 Opened 10 years ago Closed 10 years ago

unpack-diskimage.sh doesn't work with EULAs

Categories

(Release Engineering :: General, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

Attachments

(1 file)

Some of our shipping productions (Thunderbird 2.0.0.x specifically) still have a EULA displayed when mounting a dmg. We used to work around this by mounting with an expect script, but we did away with that in bug 499506. This ended up breaking the Thunderbird 2.0.0.23 release because l10nverify failed to mount DMGs.
OK, so I've backed out bug 499506 temporarily, so we can run l10nverify and update_verify. I'll re-land them afterwards and we can have a long term fix in this bug.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
This is also affecting Sunbird builds, noticed in bug 510348
Blocks: 510348
I think this should do the trick. I've tested it in a tb2.0.0.x scenario and a 3.5.x one. It does make the assumption that only builds on 10.4 require installdmg.ex - which is true for Firefox/Thunderbird, but I don't know about other products. By the sounds of it, this assumption is true for SeaMonkey and Sunbird too - Kairo/Phillipp, can you confirm that?
Attachment #395890 - Flags: review?(philipp)
Attachment #395890 - Flags: review?(kairo)
Attachment #395890 - Flags: review?(ccooper)
Comment on attachment 395890 [details] [diff] [review]
put back installdmg.ex logic for 10.4 machines

+            # 10.4. For these, we need to use an expect script to monut them.

Typo in "mount," otherwise looks fine to me.
Attachment #395890 - Flags: review?(ccooper) → review+
Attachment #395890 - Flags: review?(kairo) → review+
Comment on attachment 395890 [details] [diff] [review]
put back installdmg.ex logic for 10.4 machines

Looks good to me. I think Sunbird isn't doing any further releases, so not sure if Philipp still cares.
(In reply to comment #5)
> (From update of attachment 395890 [details] [diff] [review])
> Looks good to me. I think Sunbird isn't doing any further releases, so not sure
> if Philipp still cares.

From a conversation on IRC, the Sunbird folks will certainly care, but for a different reason. A similar fix will be needed to make 'make unpack' work on OSX for Sunbird. Without it, l10n-merge repacks fail to produce l10n builds.
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 395890 [details] [diff] [review] [details])
> > Looks good to me. I think Sunbird isn't doing any further releases, so not sure
> > if Philipp still cares.
> 
> From a conversation on IRC, the Sunbird folks will certainly care, but for a
> different reason. A similar fix will be needed to make 'make unpack' work on
> OSX for Sunbird. Without it, l10n-merge repacks fail to produce l10n builds.

Is that being tracked in the blocking bug?
Comment on attachment 395890 [details] [diff] [review]
put back installdmg.ex logic for 10.4 machines

Seems that this patch is valid regardless of the Sunbird situation. Landed it:
changeset:   359:92e9709dbe76
Attachment #395890 - Flags: review?(philipp) → checked-in+
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (From update of attachment 395890 [details] [diff] [review] [details] [details])
> > > Looks good to me. I think Sunbird isn't doing any further releases, so not sure
> > > if Philipp still cares.
> > 
> > From a conversation on IRC, the Sunbird folks will certainly care, but for a
> > different reason. A similar fix will be needed to make 'make unpack' work on
> > OSX for Sunbird. Without it, l10n-merge repacks fail to produce l10n builds.
> 
> Is that being tracked in the blocking bug?

I'm going to assume this is the case.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.