510208 - unpack-diskimage.sh doesn't work with EULAs

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Some of our shipping productions (Thunderbird 2.0.0.x specifically) still have a EULA displayed when mounting a dmg. We used to work around this by mounting with an expect script, but we did away with that in bug 499506. This ended up breaking the Thunderbird 2.0.0.23 release because l10nverify failed to mount DMGs.

Comment 1

[[e-mail] (:bhearsum)]

OK, so I've backed out bug 499506 temporarily, so we can run l10nverify and update_verify. I'll re-land them afterwards and we can have a long term fix in this bug.

Comment 2

[Philippe M. Chiasson (:gozer)]

This is also affecting Sunbird builds, noticed in bug 510348

Comment 3

[[e-mail] (:bhearsum)]

Attachment: put back installdmg.ex logic for 10.4 machines

I think this should do the trick. I've tested it in a tb2.0.0.x scenario and a 3.5.x one. It does make the assumption that only builds on 10.4 require installdmg.ex - which is true for Firefox/Thunderbird, but I don't know about other products. By the sounds of it, this assumption is true for SeaMonkey and Sunbird too - Kairo/Phillipp, can you confirm that?

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 395890 [details] [diff] [review]
put back installdmg.ex logic for 10.4 machines

+            # 10.4. For these, we need to use an expect script to monut them.

Typo in "mount," otherwise looks fine to me.

Comment 5

[Robert Kaiser]

Comment on attachment 395890 [details] [diff] [review]
put back installdmg.ex logic for 10.4 machines

Looks good to me. I think Sunbird isn't doing any further releases, so not sure if Philipp still cares.

Comment 6

[Philippe M. Chiasson (:gozer)]

(In reply to comment #5)
> (From update of attachment 395890 [details] [diff] [review])
> Looks good to me. I think Sunbird isn't doing any further releases, so not sure
> if Philipp still cares.

From a conversation on IRC, the Sunbird folks will certainly care, but for a different reason. A similar fix will be needed to make 'make unpack' work on OSX for Sunbird. Without it, l10n-merge repacks fail to produce l10n builds.

Comment 7

[[e-mail] (:bhearsum)]

(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 395890 [details] [diff] [review] [details])
> > Looks good to me. I think Sunbird isn't doing any further releases, so not sure
> > if Philipp still cares.
> 
> From a conversation on IRC, the Sunbird folks will certainly care, but for a
> different reason. A similar fix will be needed to make 'make unpack' work on
> OSX for Sunbird. Without it, l10n-merge repacks fail to produce l10n builds.

Is that being tracked in the blocking bug?

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 395890 [details] [diff] [review]
put back installdmg.ex logic for 10.4 machines

Seems that this patch is valid regardless of the Sunbird situation. Landed it:
changeset:   359:92e9709dbe76

Comment 9

[[e-mail] (:bhearsum)]

(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > (From update of attachment 395890 [details] [diff] [review] [details] [details])
> > > Looks good to me. I think Sunbird isn't doing any further releases, so not sure
> > > if Philipp still cares.
> > 
> > From a conversation on IRC, the Sunbird folks will certainly care, but for a
> > different reason. A similar fix will be needed to make 'make unpack' work on
> > OSX for Sunbird. Without it, l10n-merge repacks fail to produce l10n builds.
> 
> Is that being tracked in the blocking bug?

I'm going to assume this is the case.