If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Window is not un-minimized from Dock when selected in the Window menu

VERIFIED FIXED in mozilla1.9.3a1

Status

()

Core
Widget: Cocoa
VERIFIED FIXED
8 years ago
8 years ago

People

(Reporter: Håkan Waara, Assigned: Håkan Waara)

Tracking

(Depends on: 1 bug, {verified1.9.2})

unspecified
mozilla1.9.3a1
x86
Mac OS X
verified1.9.2
Points:
---

Firefox Tracking Flags

(status1.9.2 beta4-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Firefox 3.6a1, Mac OS X 10.5

1. Minimize a window to the dock
2. Select it in the Window menu

Expected result:

The window should be shown again, "un-minimized"

Actual result:

Nothing happens
(Assignee)

Comment 1

8 years ago
Created attachment 394397 [details] [diff] [review]
Patch v1

Here's a patch to the mac window menu. Apparently all we did was focus the window, which does nothing for minitiaturized windows.

Can someone help me with the review request? I've been away to long to know who is good for this.
Assignee: nobody → hwaara
Attachment #394397 - Flags: review?
(Assignee)

Updated

8 years ago
Attachment #394397 - Flags: review? → review?(gavin.sharp)
Attachment #394397 - Flags: review?(gavin.sharp) → review+
Håkan, are you going to land this sometime?
(Assignee)

Comment 3

8 years ago
Sorry, I've been so busy. Can I just check it in to m-c without approval? Are there other repositories that want it immediately?
Yes, the trunk is open. We'd probably also take it on 1.9.2 (needs approval
Target Milestone: --- → mozilla2.0
(Assignee)

Comment 5

8 years ago
It would be great if someone can check this in for me, I don't have the time to do it now...

Updated

8 years ago
Blocks: 516027
I can do it.
http://hg.mozilla.org/mozilla-central/rev/3a6c1c8137f5
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: mozilla2.0 → mozilla1.9.3a1
(Assignee)

Comment 8

8 years ago
Thanks Markus!

Comment 9

8 years ago
Comment on attachment 394397 [details] [diff] [review]
Patch v1

Baked on the trunk for a bit. No apparent issues, looks to be needed on 1.9.2.
Attachment #394397 - Flags: approval1.9.2?

Updated

8 years ago
Duplicate of this bug: 516027
No longer blocks: 516027
Duplicate of this bug: 302172
Duplicate of this bug: 262201
So what about the diamond which is displayed for other applications right before the window name? Do we want this too? I would think so and can file a follow-up bug.

Looks great. Thanks for the work Hakan! Marking as verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091014 Minefield/3.7a1pre ID:20091014030825
Status: RESOLVED → VERIFIED
Depends on: 522471
I've filed bug 522471 for the diamond issue.
Duplicate of this bug: 526907
Duplicate of this bug: 527898
Mike, could we consider this bug for 1.9.2? It's really simple and will help people on OS X to get their minimized windows back. Looks like it was missed in the approval queue.
Comment on attachment 394397 [details] [diff] [review]
Patch v1

a192=beltzner
Attachment #394397 - Flags: approval1.9.2? → approval1.9.2+
Keywords: checkin-needed
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/90e14ae40016
status1.9.2: --- → final-fixed
Keywords: checkin-needed
Verified fixed on 1.9.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b5pre) Gecko/20091126 Namoroka/3.6b5pre ID:20091126033851
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.