510221 - Window is not un-minimized from Dock when selected in the Window menu

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Håkan Waara]

Firefox 3.6a1, Mac OS X 10.5

1. Minimize a window to the dock
2. Select it in the Window menu

Expected result:

The window should be shown again, "un-minimized"

Actual result:

Nothing happens

Comment 1

[Håkan Waara]

Attachment: Patch v1

Here's a patch to the mac window menu. Apparently all we did was focus the window, which does nothing for minitiaturized windows.

Can someone help me with the review request? I've been away to long to know who is good for this.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Håkan, are you going to land this sometime?

Comment 3

[Håkan Waara]

Sorry, I've been so busy. Can I just check it in to m-c without approval? Are there other repositories that want it immediately?

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Yes, the trunk is open. We'd probably also take it on 1.9.2 (needs approval

Comment 5

[Håkan Waara]

It would be great if someone can check this in for me, I don't have the time to do it now...

Comment 6

[Markus Stange [:mstange]]

I can do it.

Comment 7

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/3a6c1c8137f5

Comment 8

[Håkan Waara]

Thanks Markus!

Comment 9

[Kevin Brosnan]

Comment on attachment 394397 [details] [diff] [review]
Patch v1

Baked on the trunk for a bit. No apparent issues, looks to be needed on 1.9.2.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So what about the diamond which is displayed for other applications right before the window name? Do we want this too? I would think so and can file a follow-up bug.

Looks great. Thanks for the work Hakan! Marking as verified fixed with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091014 Minefield/3.7a1pre ID:20091014030825

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I've filed bug 522471 for the diamond issue.

Comment 17

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mike, could we consider this bug for 1.9.2? It's really simple and will help people on OS X to get their minimized windows back. Looks like it was missed in the approval queue.

Comment 18

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 394397 [details] [diff] [review]
Patch v1

a192=beltzner

Comment 19

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/90e14ae40016

Comment 20

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.2 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b5pre) Gecko/20091126 Namoroka/3.6b5pre ID:20091126033851