STR: 1. Load https://preview.addons.mozilla.org/en-US/editors/performance 2. Click on any add-on listed Expected: A link to the reviews for that add-on Actual: https://preview.addons.mozilla.org/en-US/editors/review/
Scott, could you look into this? I can make you a co-author, if that helps.
I don't have admin on preview, but it works for me on my dev copy (as both editor and admin user). You mentioned making me a co-author: authors are not allowed to view reviews of their own add-ons. I think they are redirected to the main reviews page if they try. This is probably what you are seeing? Should this behavior be altered?
(In reply to comment #2) > I think they are redirected to the main reviews page if they > try. Correction: you would see a notice "self-reviews are not allowed" and be redirected to the /editors/queue.
Created attachment 394977 [details] [diff] [review] No Linking Patch Apparently not all approvals have a file associated with them - almost exclusively those with reviewtype=='info'. Since reviews require a valid file_id, this patch simply removes the review link for these approvals. Is there anything else that these approvals could link to?
Assignee: nobody → smccammon
Status: NEW → ASSIGNED
Attachment #394977 - Flags: review?(clouserw)
Attachment #394977 - Flags: review?(clouserw) → review+
fixed in r49618
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Verified FIXED (at least for the case filed here) on https://preview.addons.mozilla.org/en-US/editors/performance; thanks, Scott!
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.