Closed Bug 510356 Opened 15 years ago Closed 15 years ago

Hard coded wikiapproval_prefix value

Categories

(support.mozilla.org :: General, defect)

defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: paulc, Assigned: paulc)

References

Details

(Whiteboard: tiki_fixed)

Attachments

(1 file)

In tiki-editpage.php sometimes checks are done for '*' instead of $prefs['wikiapproval_prefix']
This can be found in tiki-editpage.php in multiple instances.
Attached patch patch, v1Splinter Review
Couldn't find it hard coded anywhere else, I searched for "*" and '*'
Hopefully it's done with.
Attachment #395097 - Flags: review?(laura)
Status: NEW → ASSIGNED
Attachment #395097 - Flags: review?(laura) → review+
r49650 / r49651
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
I said prefix but I replaced with category. Absolutely ridiculous. Sorry guys, at least I found it quick.
See: r49719 / r49720
Chris has tested approval/rejection notifications over in https://bugzilla.mozilla.org/show_bug.cgi?id=446082#c27.

Verified FIXED.
Status: RESOLVED → VERIFIED
Whiteboard: tiki_bug
Already fixed upstream.
Whiteboard: tiki_bug → tiki_bug tiki_upstreamed
Whiteboard: tiki_bug tiki_upstreamed → tiki_fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: