When requesting a location from a file URL, the notification says " wants to know your location.", omitting the portion where the requesting domain would show. The sentence is incomplete without the prefix so we should indicate that a local file is requesting your location. Expected Result: "A local file wants to know your location." OR display the file name (but this would allow people to make filenames that spoof domains (ie. a file named maps.google.com). We could use the text "The file myfile.htm wants to know your location."
Fixes the case where the file:// scheme is used. Will show a message like: "The file /path/to/file wants to know your location." Are there other potential schemes where this problem could arise?
i like it!. just want to get gavin to also look at it too.
Martin, as you mentioned in the fennec bug, |path| might be pretty long. Lets let Mike think about this too.
Comment on attachment 394512 [details] [diff] [review] Prompt now shows filename if requesting URI uses the file:// scheme See bug 510565 comment 2 - same comments apply here.
Attachment #394512 - Flags: review?(gavin.sharp) → review+
Comment on attachment 394512 [details] [diff] [review] Prompt now shows filename if requesting URI uses the file:// scheme I guess this is OK, and it mirrors the web approach. I'm trying to think through use cases beyond testing where this might come up, though. In the future, I think we'll want to do something better about messaging things like this, but let's not block on the perfect idea I'm dreaming up in my head :)
Attachment #394512 - Flags: ui-review?(beltzner) → ui-review+
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.