510424 - Geolocation notification does not show requester of location for file:// URLs

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Matthew N. [:MattN]]

When requesting a location from a file URL, the notification says " wants to know your location.", omitting the portion where the requesting domain would show.  The sentence is incomplete without the prefix so we should indicate that a local file is requesting your location.  

Expected Result:
"A local file wants to know your location." 
OR 
display the file name (but this would allow people to make filenames that spoof domains (ie. a file named maps.google.com).  We could use the text "The file myfile.htm wants to know your location."

Comment 1

[Martin McNickle]

Attachment: Prompt now shows filename if requesting URI uses the file:// scheme

Fixes the case where the file:// scheme is used. Will show a message like:

"The file /path/to/file wants to know your location."

Are there other potential schemes where this problem could arise?

Comment 2

[Doug Turner (:dougt)]

i like it!.  just want to get gavin to also look at it too.

Comment 3

[Doug Turner (:dougt)]

Martin, as you mentioned in the fennec bug, |path| might be pretty long.  Lets let Mike think about this too.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 394512 [details] [diff] [review]
Prompt now shows filename if requesting URI uses the file:// scheme

See bug 510565 comment 2 - same comments apply here.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 394512 [details] [diff] [review]
Prompt now shows filename if requesting URI uses the file:// scheme

I guess this is OK, and it mirrors the web approach. I'm trying to think through use cases beyond testing where this might come up, though.

In the future, I think we'll want to do something better about messaging things like this, but let's not block on the perfect idea I'm dreaming up in my head :)

Comment 6

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/0fbd5f678509