Closed Bug 510509 Opened 15 years ago Closed 15 years ago

superfluous hbox in places toolbar binding

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Firefox 3.7a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
missed that in bug 382466
Attachment #394506 - Flags: review?(mak77)
Attachment #394506 - Flags: review?(mak77) → review+
Comment on attachment 394506 [details] [diff] [review]
patch

>diff --git a/browser/components/places/content/toolbar.xml b/browser/components/places/content/toolbar.xml

>@@ -132,17 +129,19 @@
>       </field>
>       <field name="_dropIndicator">
>         document.getAnonymousElementByAttribute(this, "class",
>                                                 "toolbar-drop-indicator")
>       </field>
>       <field name="_chevron">
>         document.getAnonymousElementByAttribute(this, "class", "chevron")
>       </field>
>-      <field name="_chevronPopup">this._chevron.lastChild</field>
>+      <field name="_chevronPopup">
>+        document.getAnonymousElementByAttribute(this, "anonid", "chevronPopup")
>+      </field>

nit: any reason to look for the anonymous element into "this" rather than into "this._chevron"?
once this patch lands i'll merge it into bug 382466 and ask approval1.9.2 on the merged patch.
Depends on: 382466
(In reply to comment #1)
> nit: any reason to look for the anonymous element into "this" rather than into
> "this._chevron"?

getAnonymousElementByAttribute's first argument shouldn't be an anonymous node, I think.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/769f3f3ac45b
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
pushed on 1.9.2 with bug 382466.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: