Closed
Bug 51053
Opened 24 years ago
Closed 24 years ago
closePopup doesn't work on menu boxes
Categories
(Core :: XUL, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla0.8
People
(Reporter: neil, Assigned: mikepinkerton)
References
()
Details
(Keywords: helpwanted)
If the ...QueryInterface(Components.interfaces.nsIPopupSetBoxObject) throws an exception then the ...QueryInterface(Components.interfaces.nsIMenuBoxObject) is never called.
Assignee | ||
Comment 1•24 years ago
|
||
nobody dies --> future. a patch would be quite helpful.
Keywords: helpwanted
Target Milestone: --- → Future
Reporter | ||
Comment 2•24 years ago
|
||
I can give you before and after code snippets if that will help.
Assignee | ||
Comment 3•24 years ago
|
||
sure ;)
Reporter | ||
Comment 4•24 years ago
|
||
This code appears in xulBindings.xml at lines 355, 369, 383 and 395: try { var popupSetBox = this.parentNode.boxObject.QueryInterface(Component s.interfaces.nsIPopupSetBoxObject); var menuBox = this.parentNode.boxObject.QueryInterface(Components.in terfaces.nsIMenuBoxObject); } catch(e) {} It should read as follows: try { var popupSetBox = this.parentNode.boxObject.QueryInterface(Component s.interfaces.nsIPopupSetBoxObject); } catch(e) {} try { var menuBox = this.parentNode.boxObject.QueryInterface(Components.in terfaces.nsIMenuBoxObject); } catch(e) {}
Assignee | ||
Updated•24 years ago
|
Assignee | ||
Comment 5•24 years ago
|
||
fix checked in. thanks!!!
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Target Milestone: mozilla0.9 → mozilla0.8
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•