closePopup doesn't work on menu boxes

RESOLVED FIXED in mozilla0.8

Status

()

Core
XUL
P3
normal
RESOLVED FIXED
18 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: Mike Pinkerton (not reading bugmail))

Tracking

({helpwanted})

Trunk
mozilla0.8
x86
Windows 95
helpwanted
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

18 years ago
If the ...QueryInterface(Components.interfaces.nsIPopupSetBoxObject) throws an
exception then the ...QueryInterface(Components.interfaces.nsIMenuBoxObject) is
never called.
(Assignee)

Comment 1

17 years ago
nobody dies --> future. a patch would be quite helpful.
Keywords: helpwanted
Target Milestone: --- → Future
(Reporter)

Comment 2

17 years ago
I can give you before and after code snippets if that will help.
(Assignee)

Comment 3

17 years ago
sure ;)
(Reporter)

Comment 4

17 years ago
This code appears in xulBindings.xml at lines 355, 369, 383 and 395:
          try {
            var popupSetBox = this.parentNode.boxObject.QueryInterface(Component
s.interfaces.nsIPopupSetBoxObject);
            var menuBox = this.parentNode.boxObject.QueryInterface(Components.in
terfaces.nsIMenuBoxObject);
          } catch(e) {}
It should read as follows:
          try {
            var popupSetBox = this.parentNode.boxObject.QueryInterface(Component
s.interfaces.nsIPopupSetBoxObject);
          } catch(e) {}
          try {
            var menuBox = this.parentNode.boxObject.QueryInterface(Components.in
terfaces.nsIMenuBoxObject);
          } catch(e) {}
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Keywords: patch
Target Milestone: Future → mozilla0.9
(Assignee)

Comment 5

17 years ago
fix checked in. thanks!!!
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Target Milestone: mozilla0.9 → mozilla0.8

Updated

9 years ago
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: jrgmorrison → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.