510549 - Default Theme 2.0 missing icon for mail.tabs.closeButtons = 3

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Chris Brown]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.1) Gecko/20090715 Thunderbird/3.0b3

Close tab icon at right side of tab bar missing when mail.tabs.closeButtons set to 3 when using Default Theme 3.5.2. When mouse-over it's location a very small undistinguished box appears which can be used to close the tab. No 'X' icon is visable.

Reproducible: Always

Steps to Reproduce:
1. In Config Editor, set mail.tabs.closeButtons = 3
2. Open multiple tabs.
3. Observe sliver of space to right of List all tabs icon is blank.
4. Mouse over this space and observe highlight of button (though without icon)
Actual Results:  
Icon is missing.

Expected Results:  
See an 'X' close-tab icon.

See also Bug 396004

Comment 1

[Onno Ekker [:nONoNonO UTC+1]]

Is this default theme called 3.5.2? Anyway, the 'X'-button is removed from the tabs when setting this pref, and a small space appears, just a described, so it looks like it is designed to work...

Comment 2

[Chris Brown]

Correction: Thunderbird (default) 2.0, The default theme

Comment 3

[Ludovic Hirlimann [:Usul]]

Wouldn't this be nice to have for final ?

Comment 4

[Andreas Nilsson (:andreasn)]

What does mail.tabs.closeButtons = 3 do?

Comment 5

[Andreas Nilsson (:andreasn)]

Found out what it did. http://kb.mozillazine.org/Browser.tabs.closeButtons

Comment 7

[Achim]

Win XP SP3

TB 3.0 german, theme default 3.0, screen 1920x1080, resolution 32bit, XP desktop theme "classical", TB with activated or deactivated add-ons: X-button on the right side is one quarter of a normal X-button and and without contents, it is visible only with the mouse pointer directly scrolling over it.

Installed TB 3.0 english on a fresh installed machine, screen 1920x1080 32bit or 1024x768 32bit or 16bit without any add-ons: X-button on the right side is normal in size but only visible with mousepointer scrolling over it.

Installed TB 3.0 german on a fresh installed machine as before: same result.

Changed XP desktop theme (not TB theme !) from "Win XP" to "classical": button shrinks to one quarter.

So, the shrinking of the button to one quarter in size of a "normal" X-button results from WinXP classical theme. 

But what removes the color and the X in the button in both cases ?





In all cases button works on click as expected.

Comment 8

[Achim]

Win XP SP1 and additional ethernet driver, no other sw, no modification, fresh installed.

TB 3.0 german, no modifcation except mail.tabs.closeButtons=3 and mail account defined. Resolution 1024x768 with 16 and 32 bit, standard vga.
Close button on the right site: no shrinking but even no content or color. Button is visible "all in grey" and empty (no X) if mousepointer scrolls over it.

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Something not working right with a hidden preference wouldn't stop a release from shipping if it were the last bug standing.  Setting blocking3.1-.

Comment 10

[Chris Brown]

Note:

This is the last action required to finish off this 2 1/2 year series of bugs and modifications:

2007-08-25 Bug 393666 Figure out the story for mail tab behavior prefs.
2007-09-12 Bug 396004 Make mail.tabs.closeButtons=3 actually work
2008-05-12 Bug 433368 Setting mail.tabs.closeButtons to 3 doesn't work.
2009-10-02 Bug 520257 Tab close button moved to right doesn't contain icon

If anyone knows how to put an icon in the theme, I think it'll put this to rest.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

IIRC, you just need to the icon to the appropriate jar.mn file(s) and the CSS. https://developer.mozilla.org/en/Themes is a good place to start looking for more complete and reliable info, however.

Comment 12

[Ludovic Hirlimann [:Usul]]

Mass move to the new theme component.

Comment 13

[Richard Marti (:Paenglab)]

Attachment: Show close icon

Under Win7 only added the close button without background like FF.
Under XP added also a background to fit with all-tabs-button.

Comment 14

[Richard Marti (:Paenglab)]

Attachment: Tab bar close button under XP

How it looks under XP.

The tabs-alltabs-button's dropmarker isn't centered (this was already before this patch). If you like it to be centered, I can add for .tabs-alltabs-button > .toolbarbutton-menu-dropmarker a -moz-margin-start: -4px;

Comment 15

[Andreas Nilsson (:andreasn)]

Comment on attachment 529468 [details] [diff] [review]
Show close icon

Looks great!

Comment 16

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 529468 [details] [diff] [review]
Show close icon

Review of attachment 529468 [details] [diff] [review]:

Yeah, this looks good to me too.  r=me.

Comment 17

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/5cbad98a8394

Comment 18

[Chris Brown]

Yay!