510616 - Toolbar flickers when being floated due to offset in sidebar-visibility logic

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Roy Frostig :froystig]

We try to float the toolbar before every slight scroll, but we do this based on the visibility of sidebars before the scroll happens.  We want to account for the future scrolled state in our sidebar visibility computation when deciding whether or not to float the toolbar.

Comment 1

[Roy Frostig :froystig]

Attachment: patch

... Aaaand a fix.

Comment 2

[Roy Frostig :froystig]

Attachment: patch

... Aaaand a patch on a more recent trunk.

Comment 3

[Roy Frostig :froystig]

Attachment: patch

... Aaaand one that doesn't break anything.

I'm paying attention today, really.

Comment 4

[Brian Crowder]

Brad:  This is likely the weird flicker you and I witnessed just before leaving the office?

Comment 5

[Brian Crowder]

Comment on attachment 394612 [details] [diff] [review]
patch

Drive-by (waiting for a plane w/ just enough time for some patch-sniping):

+    if (!dx) dx = 0;
+    if (!dy) dy = 0;
Our usual idiom for this is (I believe?):
dx = dx || 0;
dy = dy || 0;


The intentional misspelling of "rite" is evil.  Ritualistically so.

That's my sniping for the evening!  :)