Closed Bug 510616 Opened 11 years ago Closed 11 years ago

Toolbar flickers when being floated due to offset in sidebar-visibility logic

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: froystig, Unassigned)

References

Details

Attachments

(1 file, 2 obsolete files)

We try to float the toolbar before every slight scroll, but we do this based on the visibility of sidebars before the scroll happens.  We want to account for the future scrolled state in our sidebar visibility computation when deciding whether or not to float the toolbar.
Attached patch patch (obsolete) — Splinter Review
... Aaaand a fix.
Attachment #394593 - Flags: review?(pavlov)
Attached patch patch (obsolete) — Splinter Review
... Aaaand a patch on a more recent trunk.
Attachment #394593 - Attachment is obsolete: true
Attachment #394597 - Flags: review?(pavlov)
Attachment #394593 - Flags: review?(pavlov)
Attachment #394597 - Attachment is patch: true
Attachment #394597 - Attachment mime type: application/octet-stream → text/plain
Attached patch patchSplinter Review
... Aaaand one that doesn't break anything.

I'm paying attention today, really.
Attachment #394597 - Attachment is obsolete: true
Attachment #394612 - Flags: review?(pavlov)
Attachment #394597 - Flags: review?(pavlov)
Brad:  This is likely the weird flicker you and I witnessed just before leaving the office?
Comment on attachment 394612 [details] [diff] [review]
patch

Drive-by (waiting for a plane w/ just enough time for some patch-sniping):

+    if (!dx) dx = 0;
+    if (!dy) dy = 0;
Our usual idiom for this is (I believe?):
dx = dx || 0;
dy = dy || 0;


The intentional misspelling of "rite" is evil.  Ritualistically so.

That's my sniping for the evening!  :)
Attachment #394612 - Flags: review?(pavlov) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.