510649 - mingw build breakage in nsCanvasRenderingContext2D.cpp

Status: RESOLVED WORKSFORME

(Core :: Graphics: Canvas2D, defect)

Description

[:Mook]

Attachment: cast to jsint, not PRInt32

bug 509188 changed ToUint8() to take a jsint instead of a PRInt32; the call sites need to be changed to cast to that as well.  Otherwise a mingw compile fails, because PRInt32 is an int, but a jsint (int32) is a long.

It's taking a JSVAL_TO_INT() result anyway, no point casting it to non-js types.

Comment 1

[Walter Meinl]

(In reply to comment #0)
> Created an attachment (id=394627) [details]
> cast to jsint, not PRInt32
> 
> bug 509188 changed ToUint8() to take a jsint instead of a PRInt32; the call
> sites need to be changed to cast to that as well.  Otherwise a mingw compile
> fails, because PRInt32 is an int, but a jsint (int32) is a long.
> 
> It's taking a JSVAL_TO_INT() result anyway, no point casting it to non-js
> types.
Mook, it appears you attempting to patch a wrong version of the file.
The lines in question look different according to mxr
> if (JSVAL_IS_INT(vr))         ir = ToUint8(JSVAL_TO_INT(vr));
your version to patch
>if (JSVAL_IS_INT(vr))         ir = ToUint8(static_cast<PRInt32>(JSVAL_TO_INT(vr)));
bug 509188 didn't introduce a cast finally

Comment 2

[:Mook]

Comment on attachment 394627 [details] [diff] [review]
cast to jsint, not PRInt32

Bah, you're right, my local tree got confused.  Sorry about that!