510669 - Do not display the "shared searches" table if there is no search shared with you

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, enhancement)

Description

[Frédéric Buclin]

Currently, we display an empty table with <None> in it, meaning that we don't share any query with you. We should rather skip this table and update the "You may use these searches saved and shared by others:" label to "No searches are shared with you by other users".

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Guy Pyrzak]

Comment on attachment 394647 [details] [diff] [review]
patch, v1

If you're going to get rid of the tr saying None you should also get rid of the row that has the header info in it as well (IE nothing at all should show up). If a header row appears then something should say "none" or "No Shared Searches".

Comment 3

[Guy Pyrzak]

just noticed the <p> tag, so disregard the last sentence.

Comment 4

[Guy Pyrzak]

Comment on attachment 394647 [details] [diff] [review]
patch, v1

NEVERMIND. didn't see the first line of the patch. It looks fine, but I need to test it.

Comment 5

[Frédéric Buclin]

Comment on attachment 394647 [details] [diff] [review]
patch, v1

Did you read the patch carefully? If there is nothing to share, the table is not displayed *at all*, which is the topic of the bug. So if the table is displayed, we are sure there is at least one row.

Comment 6

[Frédéric Buclin]

Checking in template/en/default/account/prefs/saved-searches.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/prefs/saved-searches.html.tmpl,v  <--  saved-searches.html.tmpl
new revision: 1.21; previous revision: 1.20
done