Closed
Bug 510730
Opened 16 years ago
Closed 15 years ago
New trace-test harness format is not tinderbox-compatible.
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: graydon, Assigned: dmandelin)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
2.27 KB,
patch
|
graydon
:
review+
|
Details | Diff | Splinter Review |
The old trace-test format was something tinderbox could parse (not initially, but I changed it to be so before wiring it into "make check"). Unless I'm not seeing it, I don't think the new one writes out such a format. Therefore trace-test just went from "being checked by tinderbox" to "being ignored by tinderbox".
Maybe make the "make check" invocation pass a flag that makes it print in tinderbox-compatible form? Like the old one.
Assignee | ||
Comment 1•16 years ago
|
||
Sounds easy enough. What's the format? Is there a spec? I looked at the Tinderbox MDC article but I didn't find anything like that. The closest I found was https://developer.mozilla.org/en/How_to_add_a_build-time_test, which (apparently wrongly) says that zero-vs-nonzero exit code is enough.
Comment 2•16 years ago
|
||
That document sort of assumes you're not doing a long series of tests and assertions, in which case not printing out play-by-play details on each test is fine. For something like this, however, you want output more like what Mochitest prints out when it runs a directory of tests; the best documentation for that at the moment is really just a log of a Mochitest run. (It's probably worth adding that to the above page, just probably hasn't occurred to anyone yet.)
Assignee | ||
Comment 3•16 years ago
|
||
Attachment #394932 -
Flags: review?
Assignee | ||
Updated•16 years ago
|
Attachment #394932 -
Flags: review? → review?(graydon)
Reporter | ||
Updated•16 years ago
|
Attachment #394932 -
Flags: review?(graydon) → review+
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment 6•15 years ago
|
||
status1.9.2:
--- → beta1-fixed
Flags: wanted1.9.2+
Updated•15 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•