510731 - Remove dead code from shareglue.js

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Serge Gautherie (:sgautherie)]

(Noticed while working on bug 507601 patch B.)

The only function left in shareglue.js is MessengerSetForcedCharacterSet().

http://mxr.mozilla.org/comm-central/search?string=MessengerSetForcedCharacterSet&case=on&find=%2Fcontent%2F.*%5C.js%24
{
/mozilla/toolkit/content/charsetOverlay.js
    * line 30 -- MessengerSetForcedCharacterSet(charset);
    * line 34 -- MessengerSetForcedCharacterSet(node.getAttribute('id'));
/mailnews/base/content/shareglue.js
    * line 45 -- function MessengerSetForcedCharacterSet(aCharset)

}
This function is "called" from MailMultiplexHandler() only.

http://mxr.mozilla.org/comm-central/ident?i=MailMultiplexHandler
{
    * mozilla/toolkit/content/charsetOverlay.js
          o line 20 -- function MailMultiplexHandler(event) 
}
And that function is unused.

Comment 1

[Serge Gautherie (:sgautherie)]

And remove the references to shareglue.js too:
http://mxr.mozilla.org/comm-central/search?string=shareglue.js&case=on&find=%2Fmail
"Found 6 matching lines in 6 files"

Comment 2

[Serge Gautherie (:sgautherie)]

Damn, I was fooled by mxr: that function is used.
http://mxr.mozilla.org/mozilla-central/search?string=MailMultiplexHandler&case=on&find=%2Ftoolkit%2Fcontent%2FcharsetOverlay%5C.
{
/toolkit/content/charsetOverlay.js
    * line 20 -- function MailMultiplexHandler(event)
/toolkit/content/charsetOverlay.xul
    * line 121 -- ...enuRoot" oncommand="MailMultiplexHandler(event)" onpopupshow...
}

Morphing this bug to clean up shareglue.js.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Just remove it [Checkin: Comment 6]

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 394687 [details] [diff] [review]
(Av1) Just remove it
[Checkin: Comment 6]

Ok, r/sr=Standard8. However please ensure there is a bug on removing the toolkit -> mailnews dependency that we have at present (I'm not sure how we should fix it, just that we should).

Comment 5

[Phil Ringnalda (:philor)]

That would be ye olde bug 120970, which even has a patch, though it's a patch to break up the xpfe overlay before the toolkit overlay existed.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 394687 [details] [diff] [review]
(Av1) Just remove it
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/ee5aea1c43c6