Closed Bug 510731 Opened 12 years ago Closed 12 years ago

Remove dead code from shareglue.js

Categories

(MailNews Core :: Internationalization, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(1 file)

(Noticed while working on bug 507601 patch B.)

The only function left in shareglue.js is MessengerSetForcedCharacterSet().

http://mxr.mozilla.org/comm-central/search?string=MessengerSetForcedCharacterSet&case=on&find=%2Fcontent%2F.*%5C.js%24
{
/mozilla/toolkit/content/charsetOverlay.js
    * line 30 -- MessengerSetForcedCharacterSet(charset);
    * line 34 -- MessengerSetForcedCharacterSet(node.getAttribute('id'));
/mailnews/base/content/shareglue.js
    * line 45 -- function MessengerSetForcedCharacterSet(aCharset)

}
This function is "called" from MailMultiplexHandler() only.

http://mxr.mozilla.org/comm-central/ident?i=MailMultiplexHandler
{
    * mozilla/toolkit/content/charsetOverlay.js
          o line 20 -- function MailMultiplexHandler(event) 
}
And that function is unused.
Flags: in-testsuite-
And remove the references to shareglue.js too:
http://mxr.mozilla.org/comm-central/search?string=shareglue.js&case=on&find=%2Fmail
"Found 6 matching lines in 6 files"
Damn, I was fooled by mxr: that function is used.
http://mxr.mozilla.org/mozilla-central/search?string=MailMultiplexHandler&case=on&find=%2Ftoolkit%2Fcontent%2FcharsetOverlay%5C.
{
/toolkit/content/charsetOverlay.js
    * line 20 -- function MailMultiplexHandler(event)
/toolkit/content/charsetOverlay.xul
    * line 121 -- ...enuRoot" oncommand="MailMultiplexHandler(event)" onpopupshow...
}

Morphing this bug to clean up shareglue.js.
Component: Build Config → Internationalization
Product: Toolkit → MailNews Core
QA Contact: build-config → i18n
Summary: Remove MailMultiplexHandler() then /mailnews/.../shareglue.js → Remove dead code from shareglue.js
Attachment #394687 - Flags: superreview?(bugzilla)
Attachment #394687 - Flags: review?(bugzilla)
Attachment #394687 - Flags: superreview?(bugzilla)
Attachment #394687 - Flags: superreview+
Attachment #394687 - Flags: review?(bugzilla)
Attachment #394687 - Flags: review+
Comment on attachment 394687 [details] [diff] [review]
(Av1) Just remove it
[Checkin: Comment 6]

Ok, r/sr=Standard8. However please ensure there is a bug on removing the toolkit -> mailnews dependency that we have at present (I'm not sure how we should fix it, just that we should).
That would be ye olde bug 120970, which even has a patch, though it's a patch to break up the xpfe overlay before the toolkit overlay existed.
Comment on attachment 394687 [details] [diff] [review]
(Av1) Just remove it
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/ee5aea1c43c6
Attachment #394687 - Attachment description: (Av1) Just remove it → (Av1) Just remove it [Checkin: Comment 6]
Blocks: 507601
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b4
Blocks: 414038
You need to log in before you can comment on or make changes to this bug.