510748 - still get assertions "reflow state computed incorrect width" and "non-root frame's desired size changed during an incremental reflow"

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Timothy Nikkel (:tnikkel)]

Attachment: patch? [Checkin: Comment 5]

Bug 486065 fixed the phantom scroll bars from showing up and get rid of most of the "reflow state computed incorrect width" and "non-root frame's desired size changed during an incremental reflow" assertions but a few still remain. In gdb I get:

###!!! ASSERTION: reflow state computed incorrect width: 'reflowState.ComputedWidth() == size.width - reflowState.mComputedBorderPadding.LeftRight()', file /src/layout/base/nsPresShell.cpp, line 7169

(gdb) p reflowState.ComputedWidth()
$8 = 0
(gdb) p size.width
$9 = 60
(gdb) p reflowState.mComputedBorderPadding.LeftRight()
$10 = 120

###!!! ASSERTION: non-root frame's desired size changed during an incremental reflow: '(target == rootFrame && size.height == NS_UNCONSTRAINEDSIZE) || (desiredSize.width == size.width && desiredSize.height == size.height)', file /src/layout/base/nsPresShell.cpp, line 7186

(gdb) p desiredSize.width
$11 = 120
(gdb) p size.width
$12 = 60
(gdb) p desiredSize.height
$13 = 0
(gdb) p size.height
$14 = 0

Can we fix this by just setting the border/padding to zero on _both_ axes if either the width or the height is zero? This patch fixes the assertions for me.

Comment 1

[David Baron :dbaron:]

Comment on attachment 394695 [details] [diff] [review]
patch?
[Checkin: Comment 5]

r=dbaron

Are you getting those assertions on a test that's already in our test suites, or do we need to add another test?

Comment 2

[Timothy Nikkel (:tnikkel)]

Actually I get them on startup in chrome://browser/content/browser.xul so I don't think we need another test.

Comment 3

[David Baron :dbaron:]

Is there a test that might cause them to show up for more people, or is what makes them specific to some systems for browser.xul going to do the same for any other testcase?

Comment 4

[Timothy Nikkel (:tnikkel)]

I believe it is the same root problem as bug 486065. So browser.xul will show the problem if you have an affected configuration, but there isn't a different testcase that will trigger the problem for configurations that were unaffected by bug 486065.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 394695 [details] [diff] [review]
patch?
[Checkin: Comment 5]


http://hg.mozilla.org/mozilla-central/rev/8ea02ebd43f0

Comment 6

[David Baron :dbaron:]

Is it worth getting this in on 1.9.2?

Comment 7

[Timothy Nikkel (:tnikkel)]

I guess we want this on 1.9.2 since it is a follow up to a 1.9.2 regression fix.

Comment 8

[David Baron :dbaron:]

Comment on attachment 394695 [details] [diff] [review]
patch?
[Checkin: Comment 5]

a1.9.2=dbaron

Comment 9

[Dão Gottwald [::dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/63945ed94f40