Last Comment Bug 510798 - Omit "--- Comment 0" line for new bugs
: Omit "--- Comment 0" line for new bugs
Status: RESOLVED FIXED
: regression
Product: Bugzilla
Classification: Server Software
Component: Email Notifications (show other bugs)
: 3.4.1
: All All
: -- minor (vote)
: Bugzilla 3.4
Assigned To: Frédéric Buclin
: default-qa
Mentors:
Depends on: 457657
Blocks:
  Show dependency treegraph
 
Reported: 2009-08-16 13:05 PDT by Frederic Peters
Modified: 2010-02-28 10:53 PST (History)
2 users (show)
mkanat: approval+
mkanat: approval3.4+
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (786 bytes, patch)
2009-08-21 18:27 PDT, Frédéric Buclin
mkanat: review+
Details | Diff | Splinter Review

Description Frederic Peters 2009-08-16 13:05:15 PDT
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en; rv:1.9.0.12) Gecko/20080528 Epiphany/2.22 (Debian/2.26.3-1)
Build Identifier: 

The bugmails for submitted bugs include a comment header:
  --- Comment #0 from Frederic Peters <fpeters@0d.be> 2009-08-16 18:11:06 UTC ---

In the old GNOME bugzilla install those didn't exist.


Reproducible: Always
Comment 1 Frederic Peters 2009-08-16 13:07:02 PDT
Note this doesn't happen on this bugzilla installation (3.2.4).

FWIW the issue was initially reported, with a patch, as http://bugzilla.gnome.org/show_bug.cgi?id=591999
Comment 2 Frederic Peters 2009-08-16 13:14:03 PDT
Looks like this was introduced with bug 457657
Comment 3 Frédéric Buclin 2009-08-16 13:30:39 PDT
Yes, looks like we remove the |if $count| check in bug 457657.
Comment 4 Frédéric Buclin 2009-08-21 18:27:50 PDT
Created attachment 396016 [details] [diff] [review]
patch, v1

The right patch in the right bug...
Comment 5 Frédéric Buclin 2009-08-25 10:54:46 PDT
tip:

Checking in template/en/default/email/newchangedmail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v  <--  newchangedmail.txt.tmpl
new revision: 1.15; previous revision: 1.14
done

3.4.1:

Checking in template/en/default/email/newchangedmail.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/email/newchangedmail.txt.tmpl,v  <--  newchangedmail.txt.tmpl
new revision: 1.12.2.3; previous revision: 1.12.2.2
done

Note You need to log in before you can comment on or make changes to this bug.