510808 - Use "pressed" look for toolbarbuttons when their menu is open

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Stefan [:stefanh]]

Attachment: Fix all toolbarbutton-1 buttons

I noticed this in seamonkey, then I looked at thunderbird and it's the same: some buttons have a "almost pressed" (text-shadow is still there) state when the button menu is open, some doesn't change at all.

I believe I fixed all buttons (fingers crossed). Fixing text-shadow wasn't that expensive as I first thought it would be. We should probably fix this in toolkit.

Comment 1

[Stefan [:stefanh]]

Actually, I didn't fixed the "other actions" button in the header since I was unsure of how it'd look and it currently just have hover styling, but I fixed the "Reply" button.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

this does seem to fix up where a number of our buttons have gone wrong.  I haven't tested this but I can give a ui-r+ for helping us fit in better with the Mac theme.

Maybe you can fix the other actions button next? :)

Comment 3

[Phil Ringnalda (:philor)]

Attachment: Unrotted

Got a little bit of rot, so here's the unrotted version, with my one nit, two space indentation for the "text-shadow: none;" lines. Thanks for making us look righter!

Comment 4

[Stefan [:stefanh]]

Thanks for fixing the patch :-) I'll land this on thursday.

Comment 5

[Stefan [:stefanh]]

I did has some spare time, so I landed it now:
http://hg.mozilla.org/comm-central/rev/ef12db9fdcea