Closed Bug 510808 Opened 11 years ago Closed 11 years ago

Use "pressed" look for toolbarbuttons when their menu is open

Categories

(Thunderbird :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b4

People

(Reporter: stefanh, Assigned: stefanh)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Fix all toolbarbutton-1 buttons (obsolete) — Splinter Review
I noticed this in seamonkey, then I looked at thunderbird and it's the same: some buttons have a "almost pressed" (text-shadow is still there) state when the button menu is open, some doesn't change at all.

I believe I fixed all buttons (fingers crossed). Fixing text-shadow wasn't that expensive as I first thought it would be. We should probably fix this in toolkit.
Attachment #394751 - Flags: review?(philringnalda)
Actually, I didn't fixed the "other actions" button in the header since I was unsure of how it'd look and it currently just have hover styling, but I fixed the "Reply" button.
this does seem to fix up where a number of our buttons have gone wrong.  I haven't tested this but I can give a ui-r+ for helping us fit in better with the Mac theme.

Maybe you can fix the other actions button next? :)
Attached patch UnrottedSplinter Review
Got a little bit of rot, so here's the unrotted version, with my one nit, two space indentation for the "text-shadow: none;" lines. Thanks for making us look righter!
Attachment #394751 - Attachment is obsolete: true
Attachment #396388 - Flags: review+
Attachment #394751 - Flags: review?(philringnalda)
Thanks for fixing the patch :-) I'll land this on thursday.
I did has some spare time, so I landed it now:
http://hg.mozilla.org/comm-central/rev/ef12db9fdcea
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.