Closed Bug 510811 Opened 12 years ago Closed 12 years ago
Consistent failures in test
_contextmenu _list .xul on my machine
121 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_list.xul | menu left 0 - got 388, expected 387 .... 124 ERROR TEST-UNEXPECTED-FAIL | /tests/toolkit/content/tests/widgets/test_contextmenu_list.xul | menu left 1 - got 391, expected 390
This fixes it for me, s/floor/round. The other change to isRoundedX and isRoundedY is just some cleanup (uses some new properties and uses is instead of faking it with an ok).
Assignee: nobody → highmind63
Status: NEW → ASSIGNED
Attachment #395263 - Flags: review?(neil)
Grrr, missed one.
Attachment #395266 - Flags: review?(neil) → review?(enndeakin)
Tryserver passed on both Linux and OSX (modulo unrelated errors): http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1250661151.1250668744.17541.gz&fulltext=1 http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1250661151.1250669563.26559.gz&fulltext=1 The Windows box died in middle, but I've tested this two ways to the sun on my machine, so it should work.
Comment on attachment 395266 [details] [diff] [review] patch [Checkin: Comment 7] roc wrote this part and would know about rounding as appropriate.
Attachment #395266 - Flags: review?(enndeakin) → review?(roc)
Attachment #395266 - Flags: review?(roc) → review+
Btw, is this a Linux/Win test only (at least the menu top/left part), it doesn't run at all on Mac. From my reading of the test that would mean that Mac doesn't fire oncontextmenu on a menupopup?
Comment on attachment 395266 [details] [diff] [review] patch [Checkin: Comment 7] http://hg.mozilla.org/mozilla-central/rev/6ef9993a30bf
Attachment #395266 - Attachment description: patch → patch [Checkin: Comment 7]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [c-n: m-1.9.2]
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.