510872 - Xulrunner fails to build in Qt mode.

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Tobias Hunger]

Attachment: Qt build fix

ulrunner can not be build for the Qt toolkit. The attached patch fixes this issue.

Qt is NPOTB, so any freezes do not apply.

Comment 1

[Takuro Ashie [:ashie]]

I've fixed part of it at bug 493280 (font issue).

About scroll issue, it comes from bug 507334.
So I think you should refer:

  http://hg.mozilla.org/mozilla-central/rev/e6034ded61fd

then follow it like:

  -  QRect rect(aSources[i].x, aSources[i].y,
  -             aSources[i].width, aSources[i].height);
  + const nsIntRect& r = aDestRects[i];
  + QRect rect(r.x - aDelta.x, r.y - aDelta.y, r.width, r.height);

Comment 2

[Tobias Hunger]

Attachment: updated Qt build fix.

I have updated the patch according to your comment.

Comment 3

[Takuro Ashie [:ashie]]

Comment on attachment 395593 [details] [diff] [review]
updated Qt build fix.

> -                 const nsIntRect& aSource,
> +                 const nsTArray<nsIntRect>& aSources,

aSources should be renamed to aDestRects to avoid confusing.

Comment 4

[Tobias Hunger]

Attachment: Qt build fix with updated variable names.

Comment 5

[Tobias Hunger]

Comment on attachment 395793 [details] [diff] [review]
Qt build fix with updated variable names.

This version includes the variable renaming suggested earlier.

Comment 6

[Tobias Hunger]

Ping?

Comment 7

[Takuro Ashie [:ashie]]

Did you read this document?:

  https://developer.mozilla.org/en/Hacking_Mozilla#Getting_Reviews

You should enter a email address of the module owner or a peer reviewer, not your's.
You can find a reviewer from:

  http://www.mozilla.org/owners.html

I'm just only a passerby, not a mozilla developer.

Comment 8

[Tobias Hunger]

I did not enter myself, I just did not enter any name, hoping that bugzilla will know whom to contact.

I am just listed as the review requestor (from what I understand).

Comment 9

[Tobias Hunger]

Comment on attachment 395793 [details] [diff] [review]
Qt build fix with updated variable names.

Request Mark to review this... he will know what to do:-)

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 395793 [details] [diff] [review]
Qt build fix with updated variable names.

Fixes build issues and runs Fennec

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

pushed http://hg.mozilla.org/mozilla-central/rev/8a4ff86268ea