51088 - "Rewrap" hits infinite nsAReadableString assert loop

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Akkana Peck]

Send yourself a message with long lines, by turning off "wrap long lines" then
typing some very long lines.  Read the message in mozilla, reply to it,
highlight the lines, and do "Rewrap".

You hit one of those infinite assert loops:

###!!! ASSERTION: Infinite loop: can't advance a readable iterator beyond the
end of a string: 'one_hop>0', file ../../dist/include/nsAReadableString.h, line
209

Comment 1

[Akkana Peck]

Requesting nsbeta3 since it's a crash (well, a hang, which is essentially the
same thing).

Comment 2

[Akkana Peck]

Here's the fix.  Very safe.

<       while (aOutString[i] == '\r' || aOutString[i] == '\n')
---
>       while (i < length && (aInString[i] == '\r' || aInString[i] == '\n'))

Comment 3

[Scott Collins]

That looks like the right fix to me.  r=scc if you need it.

Comment 4

[Akkana Peck]

Fixed (checked in in conjunction with a related mail/news bug).

Comment 5

[sujay]

verified in 9/12 build.