510880 - SelectHelper doesn't work in chrome

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Fabrice Desré]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5
Build Identifier: fennec 1.0b3

SelectHelper should be usable from content and chrome as an alternative to menulists.

It fails in chrome because it tries to acces wrappedJSObject properties that don't exist there.

Reproducible: Always

Comment 1

[Fabrice Desré]

Attachment: fix

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 394808 [details] [diff] [review]
fix

let's change to this pattern when checking in:

let control = (this._control.wrappedJSObject ? this._control.wrappedJSObject : this._control);

(same for selectElement check)

Comment 3

[Fabrice Desré]

Now that support for <xul:menulist> has landed, we can close this one. <h:select> is ugly in chrome anyway.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Updated patch

(In reply to comment #3)
> Now that support for <xul:menulist> has landed, we can close this one.
> <h:select> is ugly in chrome anyway.

I would rather support them even if they are ugly :)
Some extensions developers may want to use it for any reasons (I'm thinking here of cross browsers extensions that use html as a common language) and the patch is really cheap.

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I continue to think that because some extensions are "html powered" we should support it.

Comment 6

[Murali Nandigama [:murali]]

These bugs do not have a specific reviewer assigned to them and are in 'review?' state. Kindly assign a specific reviewer.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 405438 [details] [diff] [review]
Updated patch

canceling review request

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

fixed by bug 516122