Closed Bug 510965 Opened 16 years ago Closed 12 years ago

deleteWindowValue and deleteTabValue API functions need to call saveStateDelayed

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: morac, Unassigned)

Details

The deleteWindowValue and deleteTabValue API functions in SessionStore do not make a call to saveStateDelayed. As such if a tab or window value is deleted and then the browser crashes before the the next time saveStateDelayed is called, the deleted tab or window value is improperly restored. The saveStateDelayed function should be called after the value is deleted.
If no one wants to take this I can fix it myself, but as far as I'm aware there is no way to test it short of manually crashing the browser and then checking to see if the value still exists on next startup.
It would be nice if this 3+ year bug was fixed. As it is, deleting a window value still doesn't trigger a save, which forces me to work around by setting the value to "" first and then deleting it to make sure it's not incorrectly set if the browser crashes before the user does anything.
This has been fixed by bug 867143.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.