511027 - settings-dist is lame

Status: RESOLVED FIXED

(Webtools Graveyard :: Cesium, defect)

Description

[Jeff Balogh (:jbalogh)]

1. mv settings-dist settings.py

2. Put this at the bottom:

    try:
        from local_settings import *
    except ImportError:
        pass

3. Profit!

Comment 1

[Mark Hahnenberg (:mhahnenberg)]

Done.  localsettings.py does not exist in the repository as an empty file.  Perhaps it should?

Comment 2

[Wil Clouser [:clouserw]]

We use -dist files so config files are kept out of the repository and don't get accidentally committed passwords and such.  I'm just sayin'.

Comment 3

[Jeff Balogh (:jbalogh)]

First, you should call it local_settings.py because that's what other people use.  Search for "django local_settings" vs. "django localsettings".

Second, it probably shouldn't exist in your repo.  Ryan is going to be editing his, you're going to be editing yours, neither of them should go in the repo.  Let local stay local.

Make sure you update the readme to tell people about local_settings.  It would be cool if you had a section "put these things in local_settings.py and adjust accordingly" that looked like

    DB_USER = ""
    DB_HOST = ""
    MEDIA_PREFIX = ""

...and so on.

I should have filed more bugs on you this summer, they get done so fast! ;)

Comment 4

[Mark Hahnenberg (:mhahnenberg)]

Changes have been made.  Jeff, maybe you could review it to make sure it is satisfactory if you have the time? I didn't update the Readme, as that encompasses more changes than just what's in this bug.  I'll file another bug for it.

Comment 5

[Jeff Balogh (:jbalogh)]

Looks good to me, although people may be sad that you removed all the comments about what those settings mean.

Comment 6

[Mark Hahnenberg (:mhahnenberg)]

Added the comments back and committed.