Closed
Bug 511120
Opened 15 years ago
Closed 15 years ago
BrowserUI.popPopup should be called automatically
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
Details
Attachments
(1 file)
|
1.36 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
there is an unbalanced call pushPopup/popPopup in BookmarkPopup
|
Assignee | |
Comment 1•15 years ago
|
||
since it can have only one popup at a time, that sounds logical to do the popPopup call unconditionally.
Summary: BookmarkPopup.hide should call BrowserUI.popPopup → BrowserUI.popPopup should be called automatically
|
|
Assignee | |
Comment 2•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Attachment #395072 -
Flags: review?(gavin.sharp)
|
||
Updated•15 years ago
|
Attachment #395072 -
Flags: review?(gavin.sharp) → review+
|
|
||
Updated•15 years ago
|
Assignee: nobody → 21
|
|
||
Comment 3•15 years ago
|
||
https://hg.mozilla.org/mobile-browser/rev/67275f1fc489
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 4•15 years ago
|
||
is there a way to verify this?
|
||
Comment 5•15 years ago
|
||
Not without looking in MXR at the code
You need to log in
before you can comment on or make changes to this bug.
Description
•