511123 - the toolbar can be half viewable while awesomebar/larry/... is on screen

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: patch

If a user pan a bit, so the toolbar is half visible, and use the openLocation shortcut (Ctrl+L), the toolbar stay half-visible while the awesomebar is displayed, this happen also if the user click on the urlbar while it is half-visible. (Same for larry).

Furthermore when a user is editing a bookmark he can continue to pan the page, which move the toolbar.

This patch lock the toolbar in position when one of this case is encountered.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 395066 [details] [diff] [review]
patch

>diff -r 9f105820557e chrome/content/browser-ui.js
>   pushDialog : function pushDialog(aDialog) {
>     // If we have a dialog push it on the stack and set the attr for CSS
>     if (aDialog) {
>+      this.lockToolbar();
>       this._dialogs.push(aDialog);
>       document.getElementById("toolbar-main").setAttribute("dialog", "true");
>     }
>   },
> 
>   popDialog : function popDialog() {
>     // Passing null means we pop the topmost dialog
>     if (this._dialogs.length)
>       this._dialogs.pop();
> 
>     // If no more dialogs are being displayed, remove the attr for CSS
>     if (!this._dialogs.length)
>       document.getElementById("toolbar-main").removeAttribute("dialog");
>+
>+    this.unlockToolbar();
>   },

We only lock if we really push a dialog into the array. We should only unlock if we pop a dialog out of the array.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed:
https://hg.mozilla.org/mobile-browser/rev/d37810b1c86e
https://hg.mozilla.org/mobile-browser/rev/bdf53c10d6ff

Comment 3

[Joel Maher ( :jmaher ) (UTC -8) (PTO back normal Nov 17)]

ok, this seems pretty stable in the 20090827 winmo trunk nightly