Closed Bug 511237 Opened 14 years ago Closed 14 years ago

NJ merge: remove primary use of Fragmento from jsregexp

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: graydon, Assigned: graydon)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file, 1 obsolete file)

remove RESideExit as well
8.43 KB, patch
dmandelin
: review+
Details | Diff | Splinter Review 
jsregexp uses Fragmento to store its fragments. this patch (which requires the prelude patch sitting in bug 511040) relocates this responsibility to a dedicated nanojit::HashMap, getting us closer to deleting more of Fragmento.

Further Fragmento-deleting patches to follow.
Attachment #395162 - Flags: review?(dmandelin)
Comment on attachment 395162 [details] [diff] [review]
move regexp fragment ownership out of fragmento

Looks great. I see that you didn't delete RESideExit; is that intentional?
Attachment #395162 - Flags: review?(dmandelin) → review+
(In reply to comment #1)
> (From update of attachment 395162 [details] [diff] [review])
> Looks great. I see that you didn't delete RESideExit; is that intentional?

Intentional in the sense of meaning to have written it that way, yes. Intentional in the sense of being certain that they can't be eliminated, not at all. I don't actually know how the regexp engine is using them. I suppose I can dig a bit and find out.

        Attachment #395162 -
        Attachment is obsolete: true

        Attachment #395175 -
        Flags: review?(dmandelin)

        Attachment #395175 -
        Flags: review?(dmandelin) → review+

    
  
Blocks: 511309

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/7b6bf42f09ff
Whiteboard: fixed-in-tracemonkey

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/7b6bf42f09ff
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

    
  
Flags: in-testsuite-

          You need to log in
          before you can comment on or make changes to this bug.