Closed Bug 511314 Opened 15 years ago Closed 15 years ago

[mozmill] Test for verifying BLUE Larry

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: u279076, Assigned: u279076)

Details

Attachments

(2 files, 1 obsolete file)

This is a placeholder bug for creating a Mozmill test script for https://litmus.mozilla.org/show_test.cgi?id=6872
Attached patch Initial patch (obsolete) — Splinter Review
Attachment #395218 - Flags: review?(hskupin)
Status: NEW → ASSIGNED
Comment on attachment 395218 [details] [diff] [review]
Initial patch

Most of the comments would also apply to bug 511318 and bug 511208 so I will leave them out here.

>+  var gETLDService = Components.classes["@mozilla.org/network/effective-tld-service;1"]
>+                       .getService(Components.interfaces.nsIEffectiveTLDService);

Sorry, that i haven't mentioned it in the green larry test but you should move this up into setupModule.
Attachment #395218 - Flags: review?(hskupin) → review-
Attached patch Rev1Splinter Review
Attachment #395218 - Attachment is obsolete: true
Attachment #397173 - Flags: review?(hskupin)
Attachment #397173 - Flags: review?(hskupin) → review-
Comment on attachment 397173 [details] [diff] [review]
Rev1

>+var testLarryBlue = function() {
>+  // Go to a "blue" website
>+  controller.open("https://www.mozilla.org/");

We cannot use this website anymore for Larry tests because it contains unencrypted content and brings up a modal sheet when loading the page. Lets move over to bugzilla.mozilla.org which works fine.

Further I have removed the usage of the string bundle and replaced it by the UtilsAPI.getProperty call.

I will attach a diff to this bug.
Attached patch Follow-upSplinter Review
Attachment #397830 - Flags: review?(ashughes)
Comment on attachment 397830 [details] [diff] [review]
Follow-up

Looks good to me.
Attachment #397830 - Flags: review?(ashughes) → review+
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/85fe3f8ecb63
http://hg.mozilla.org/qa/mozmill-tests/rev/1a2faf42af1b

I have also fixed the closing of the page info window for the grey larry test with this check-in.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Security → Mozmill Tests
Product: Firefox → Mozilla QA
QA Contact: firefox → mozmill-tests
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: