Closed Bug 511337 Opened 15 years ago Closed 15 years ago

checksetup.pl not properly throwing errors when it can't chmod a file

Categories

(Bugzilla :: Installation & Upgrading, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 3.6

People

(Reporter: mkanat, Assigned: mkanat)

Details

Attachments

(1 file)

There's a bug in Bugzilla::Install::Filesystem--it's supposed to throw a warning when it can't change the permissions of a file, but it should be using "or" instead of "||". (Right now, the way it's written, it will pretty much never throw the warning.)
Attached patch v1Splinter Review
Granting myself review as module owner, for tip only. This exposes a few interesting bugs--namely, that we can't chown/chmod files that the webserver creates. We should probably do something about that, if we can (though what, I don't know).
Assignee: installation → mkanat
Status: NEW → ASSIGNED
Attachment #395267 - Flags: review+
Checking in Bugzilla/Install/Filesystem.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/Filesystem.pm,v <-- Filesystem.pm new revision: 1.36; previous revision: 1.35 done Checking in template/en/default/setup/strings.txt.pl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/setup/strings.txt.pl,v <-- strings.txt.pl new revision: 1.15; previous revision: 1.14 done
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 395267 [details] [diff] [review] v1 >Index: Bugzilla/Install/Filesystem.pm >+ or warn install_string('chown_failed', { path => $name, >+ error => $! }) . "\n"; \n is not very useful here as you are writing to STDERR
(In reply to comment #3) > \n is not very useful here as you are writing to STDERR It's incredibly useful. It stops the "at blah blah blah line 72" part of "warn".
(In reply to comment #4) > It's incredibly useful. It stops the "at blah blah blah line 72" part of > "warn". I like to know which line of which script thrown the error.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: