fix test_results-as-visit.js

RESOLVED FIXED in mozilla1.9.3a1

Status

()

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mak, Assigned: mak)

Tracking

Trunk
mozilla1.9.3a1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Created attachment 395285 [details] [diff] [review]
patch v1.0

This test is wrong, even if actually it passes, it is based on wrong assumptions about the structure of the query and the fact one can add multiple visits with the same visit time.
Attachment #395285 - Flags: review?(dietrich)
(Assignee)

Updated

9 years ago
Blocks: 511260
this patch changes the query as well, what is that change for?
(Assignee)

Comment 2

9 years ago
if you check the query you will notice that condition is repeated 2 times in the same where, and that's useless.
Comment on attachment 395285 [details] [diff] [review]
patch v1.0

so it is! r=me.
Attachment #395285 - Flags: review?(dietrich) → review+
(Assignee)

Updated

9 years ago
Assignee: nobody → mak77
Status: NEW → ASSIGNED
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/16baceea5fe2
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9f0d9d85a5b8
status1.9.2: --- → beta1-fixed
You need to log in before you can comment on or make changes to this bug.