Closed Bug 511374 Opened 11 years ago Closed 11 years ago

fix test_results-as-visit.js

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.3a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: mak, Assigned: mak)

References

Details

Attachments

(1 file)

Attached patch patch v1.0Splinter Review
This test is wrong, even if actually it passes, it is based on wrong assumptions about the structure of the query and the fact one can add multiple visits with the same visit time.
Attachment #395285 - Flags: review?(dietrich)
Blocks: 511260
this patch changes the query as well, what is that change for?
if you check the query you will notice that condition is repeated 2 times in the same where, and that's useless.
Comment on attachment 395285 [details] [diff] [review]
patch v1.0

so it is! r=me.
Attachment #395285 - Flags: review?(dietrich) → review+
Assignee: nobody → mak77
Status: NEW → ASSIGNED
http://hg.mozilla.org/mozilla-central/rev/16baceea5fe2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
You need to log in before you can comment on or make changes to this bug.