Created attachment 395285 [details] [diff] [review] patch v1.0 This test is wrong, even if actually it passes, it is based on wrong assumptions about the structure of the query and the fact one can add multiple visits with the same visit time.
Attachment #395285 - Flags: review?(dietrich)
this patch changes the query as well, what is that change for?
if you check the query you will notice that condition is repeated 2 times in the same where, and that's useless.
Comment on attachment 395285 [details] [diff] [review] patch v1.0 so it is! r=me.
Attachment #395285 - Flags: review?(dietrich) → review+
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1
status1.9.2: --- → beta1-fixed
You need to log in before you can comment on or make changes to this bug.