511418 - static-analysis error in jsobj.cpp:4257: cannot access JS_REQUIRES_STACK variable JSContext::fp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1250689940.1250690126.27067.gz

js/src/jsobj.cpp: In function 'JSBool js_GetPropertyHelper(JSContext*, JSObject*, jsid, JSBool, jsval*)':
js/src/jsobj.cpp:4257: error: cannot access JS_REQUIRES_STACK variable JSContext::fp

Comment 1

[Jason Orendorff [:jorendorff]]

blame=jorendorff, and it looks like a real bug. I'll get to it today.

Comment 2

[Jason Orendorff [:jorendorff]]

Oops, didn't get to it yesterday. Looking now. Another error:

/home/jorendorff/dev/tracemonkey/js/src/jstracer.cpp: In function ‘unsigned int FindUndemotesInTypemaps(JSContext*, const TypeMap&, TreeInfo*, Queue<unsigned int>&)’:
/home/jorendorff/dev/tracemonkey/js/src/jstracer.cpp:4024: error: cannot call JS_REQUIRES_STACK function MarkSlotUndemotable(JSContext*, TreeInfo*, unsigned int)

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 4

[Andreas Gal :gal]

Comment on attachment 395632 [details] [diff] [review]
v1

This constant reflective PC inspection stuff is filthy.

Comment 5

[Jason Orendorff [:jorendorff]]

It is truly a dirty, dirty thing.

http://hg.mozilla.org/tracemonkey/rev/371c845dfd5d

Comment 6

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/371c845dfd5d

Comment 7

[Robert Sayre]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/e145498dc027