Closed Bug 511522 Opened 15 years ago Closed 15 years ago

TM: Notify JS_CommenceRuntimeShutdown from CycleCollector

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: gal, Assigned: gal)

References

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

patch
6.43 KB, patch
graydon
: review+
Details | Diff | Splinter Review 
The way modules are unloaded is unpredictable and leak detection sometimes runs before the XPConnect shutdown sequence starts. This patch notifies the GC engine as soon the CycleCollector knows about the impending shutdown, which is always early enough since the CC is involved in leak detection.
Attached patch patch — — Splinter Review 
Assignee: general → gal

    
  

        Attachment #395414 -
        Flags: review?(graydon)

        Attachment #395414 -
        Flags: review?(graydon) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/2e528cc8602a
Whiteboard: fixed-in-tracemonkey

    
    

    
  
Removed debug printfs that confuse trace-tests:

http://hg.mozilla.org/tracemonkey/rev/85832269fb64

    
    

    
  
Looks like this finally fixed it. Debugging leaks really builds character.

    
    

    
  
looks like this caused an xpcshell test to fail on Windows:

_tests\xpcshell\test_browser_places\unit\test_browserGlue_shutdown.js
test failed (with xpcshell return code: -1073741819)


looks 100% reproducible on windows, I'll see about that here.

    
    

    
  
Do we need the (sometimes mis-indented) #ifdef DEBUG fprintf(stderr, ...) calls?

/be

    
    

    
  
Those are gone.

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/2e528cc8602a
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: