Escape characters showing up in Twitter when sharing add-on/collections

VERIFIED FIXED

Status

VERIFIED FIXED
10 years ago
3 years ago

People

(Reporter: stephend, Assigned: cesar)

Tracking

Details

(URL)

Attachments

(2 attachments)

(Reporter)

Description

10 years ago
STR:

1. Load https://preview.addons.mozilla.org/en-US/firefox/addon/8585
2. Click the "Share this Add-on" link, and choose Twitter (also shows up onhttps://preview.addons.mozilla.org/en-US/firefox/collection/webdeveloper for collections)
3. Look at the output

Expected Results:

stephend's 3000!!! 2.0 :: Add-ons for Firefox https://preview.addons.mozilla.org/en-US/firefox/addon/8585

Actual Results:

stephend's 3000!!! 2.0 :: Add-ons for Firefox https://preview.addons.mozilla.org/en-US/firefox/addon/8585
(Assignee)

Updated

10 years ago
Assignee: nobody → cdolivei.bugzilla
This will also affect collection's "share this" links.
(Assignee)

Comment 2

10 years ago
Created attachment 397536 [details] [diff] [review]
v1

Simple fix. html_entity_decode doesn't decode single quotes by default.
Attachment #397536 - Flags: review?(fwenzel)
Attachment #397536 - Flags: review?(fwenzel) → review+
(Assignee)

Comment 4

9 years ago
In r53010. Sorry. I am super lame for not checking this in earlier.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: push-needed
Resolution: --- → FIXED
(Assignee)

Comment 5

9 years ago
Sorry for bugspam. Also in r53012 because only half the patch was in my repo for some strange reason.
(Reporter)

Comment 6

9 years ago
Created attachment 405170 [details]
Post-fix screenshot
(Reporter)

Comment 7

9 years ago
Verified FIXED; thanks, Cesar!
Status: RESOLVED → VERIFIED
(Reporter)

Updated

9 years ago
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.