Closed
Bug 511527
Opened 15 years ago
Closed 15 years ago
Escape characters showing up in Twitter when sharing add-on/collections
Categories
(addons.mozilla.org Graveyard :: Public Pages, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: stephend, Assigned: u278084)
References
()
Details
Attachments
(2 files)
|
1.17 KB,
patch
|
wenzel
:
review+
|
Details | Diff | Splinter Review |
|
220.60 KB,
image/png
|
Details |
Post-fix screenshot
STR:
1. Load https://preview.addons.mozilla.org/en-US/firefox/addon/8585
2. Click the "Share this Add-on" link, and choose Twitter (also shows up onhttps://preview.addons.mozilla.org/en-US/firefox/collection/webdeveloper for collections)
3. Look at the output
Expected Results:
stephend's 3000!!! 2.0 :: Add-ons for Firefox https://preview.addons.mozilla.org/en-US/firefox/addon/8585
Actual Results:
stephend's 3000!!! 2.0 :: Add-ons for Firefox https://preview.addons.mozilla.org/en-US/firefox/addon/8585
|
||
Comment 1•15 years ago
|
||
This will also affect collection's "share this" links.
Simple fix. html_entity_decode doesn't decode single quotes by default.
Attachment #397536 -
Flags: review?(fwenzel)
|
||
Updated•15 years ago
|
Attachment #397536 -
Flags: review?(fwenzel) → review+
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 397536 [details] [diff] [review]
v1
Thanks!
In r53010. Sorry. I am super lame for not checking this in earlier.
Sorry for bugspam. Also in r53012 because only half the patch was in my repo for some strange reason.
|
Reporter | |
Comment 6•15 years ago
|
||
|
|
Reporter | |
Updated•15 years ago
|
Keywords: push-needed
|
||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•