511568 - CE shunt not overriding std::nothrow operator new

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: add std::nothrow operator new variants to shunt

The shunt is missing overrides of the std::nothrow variants of operator new, causing problems when it's used; we don't use it a lot, but we do in canvas, where we were ending up using the system allocator but calling jemalloc's delete.

This patch overrides std::nothrow variants of operator new.  It also makes the C++ new/delete operators all inline, which saves us an extra function call; it means that we don't export these symbols from mozce_shunt though, but that seems to be fine.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: better patch

Better patch, now going back to exporting as well as inlining.

The trick seemed to be to use inline instead of __forceinline, and to not try to export the placement new operators (but still define them inline), since they're essentially noops.

Also using declspec(dllimport) or dllexport didn't work -- compiler complained about changing the linkage of a built-in function declaration.

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 395503 [details] [diff] [review]
better patch


>+#include <stdlib.h>
use jemalloc.h directly


>+// actually throw for us.  Note that these are inline, so they
>+// are not exported from the shunt.
fix comment (as you pointed out on irc)

>+;; operator new[] nothrow
>+??_U@YAPAXIABUnothrow_t@std@@@Z
> ;; operator delete[]
> ??_V@YAXPAX@Z
>+
> malloc
nit, don't need the extra space

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/9230b5d26c85
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/3fe9b88d09c9