511627 - Implement a dialog system for fennec

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Fabrice Desré]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5
Build Identifier: fennec 1.0b3

Create a non-windowed dialog system for fennec.

Reproducible: Always

Comment 1

[Fabrice Desré]

Attachment: v1

This patch add support for dialogs loaded from remote files :
<dialog xmlns="$XUL_NS" 
        onload="..." 
        onclose="..."
        script="js file to load in dialog scope"
        closebutton="true|false">
 <label value="hello world dialog !"/>
 <button class="button-dark" oncommand=""/>
</dialog>

Opening a dialog is done using the openDialog(uri, args) available in browser.js

For now all dialogs are modal.

Comment 2

[Fabrice Desré]

Attachment: v1.1

removed nsIPrompt implementation from this patch, and included jar.mn

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 395568 [details] [diff] [review]
v1.1

>diff -r 30e5022551d0 chrome/content/bindings/dialog.xml

>+      <constructor><![CDATA[
>+        if (!this.hasAttribute(orient))

"orient"  ?

>diff -r 30e5022551d0 chrome/content/browser.js

>+  // create a full-screen semi-opaque box as a background 
>+  let back = document.createElement("box");
>+  back.setAttribute("align", "center");
>+  back.setAttribute("pack", "center");
>+  back.setAttribute("style", "background-color: rgba(128,128,128,0.5)");

I'm think we should add these to a CSS rule and not add them explicitly. Just add a .className = "modal-block"

>+  // should allow non-modal dialogs, but doesn't work
>+  //dialog = parent.insertBefore(document.importNode(doc, true), selectContainer);

Just remove for now

Comment 4

[Fabrice Desré]

Attachment: v1.2

Addresses issues in comment #3, and adds a "modal" parameter to open dialog to avoid a signature change when the non-modal behavior will be fixed.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 396763 [details] [diff] [review]
v1.2

>diff -r 4f92ef5a340a chrome/content/browser.css

>+.modal-block {
>+    -moz-box-align: center;
>+    -moz-box-pack: center;
>+    background-color: rgba(128,128,128,0.5);
>+}

Let's put this in the themes/hildon/browser.css and themes/wince/browser.css files instead

>+function openDialog(src, modal, arguments) {

Let's skip the modal parameter for now. Everything will just open as modal. We can fix later.

r+ with those nits fixed

Comment 6

[Fabrice Desré]

> 
> Let's skip the modal parameter for now. Everything will just open as modal. We
> can fix later.

Skipping the modal parameter is probably ok for the "core" of Fennec, but extensions developers will also be impacted. That was my main reason to add it now even if not supported.

Comment 7

[Fabrice Desré]

Attachment: v1.3

Addresses issues in comment #5

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed: https://hg.mozilla.org/mobile-browser/rev/c21d7d3748a8

renamed "openDialog" -> "importDialog"